Merge pull request #275 from nutnnut/fix-monster-crystal-level #patch

fix maker monster crystal level calculation

config.yaml

@@ -344,7 +344,7 @@ server:
     USE_ENHANCED_CRAFTING: false     #Apply chaos scroll on every equip crafted.
     SCROLL_CHANCE_ROLLS: 1         #Number of rolls for success on a scroll, set 1 for default.
     CHSCROLL_STAT_RATE: 1               #Number of rolls of stat upgrade on a successfully applied chaos scroll, set 1 for default.
-    CHSCROLL_STAT_RANGE: 6              #Stat upgrade range (-N, N) on chaos scrolls.
+    CHSCROLL_STAT_RANGE: 5              #Stat upgrade range (-N, N) on chaos scrolls.
 
     #Beginner Skills Configuration
     USE_ULTRA_NIMBLE_FEET: false     #Massive speed & jump upgrade.

handbook/Commands.txt

@@ -0,0 +1,200 @@
+Common Commands:
+@help - Show available commands.
+@commands - Show available commands.
+@droplimit - Check drop limit of current map.
+@time - Show current server time.
+@credits - Show credits. These people made the server possible.
+@uptime - Show server online time.
+@gacha - Show gachapon rewards.
+@dispose - Dispose to fix NPC chat.
+@changel - Change language settings
+@equiplv - Show levels of all equipped items.
+@showrates - Show all world/character rates.
+@rates - Show your rates.
+@online - Show all online players.
+@gm- Send a message to the game masters.
+@reportbug - Send in a bug report.
+@points - Show point total.
+@joinevent - Join active event.
+@leaveevent-Leave active event.
+@ranks - Show player rankings.
+@str - Assign AP into STR.
+@dex - Assign AP into DEX.
+@int - Assign AP into INT.
+@luk - Assign AP into LUK.
+@enableauth - Enable PIC code by resetting the cooldown.
+@toggleexp - Toggle enable/disable all exp gain.
+@mylawn - Claim ownership of the current map.
+@bosshp - Show HP of bosses on current map.
+@mobhp - Show HP of mobs on current map.
+
+
+Donator Commands:
+@whatdropsfrom - Show what items drop from a mob.
+@whodrops - Show what drops an item.
+@buffme - Activate GM buffs on self.
+@goto - Warp to a predefined map.
+
+
+JrGM Commands:
+!recharge - Recharge and refill all USE items.
+!whereami - Show info about objects on current map.
+!hide - Hide from players.
+!unhide - Toggle Hide.
+!sp - Set available SP.
+!ap - Set available AP.
+!empowerme - Activate all useful buffs.
+!buffmap - Give GM buffs to the whole map.
+!buff - Activate a buff.
+!bomb - Bomb a player, dealing damage.
+!dc - Disconnect a player.
+!cleardrops - Clear drops by player.
+!clearslot - Clear all items in an inventory tab.
+!clearsavelocs - Clear saved locations for a player.
+!warp - Warp to a map.
+!warphere - Move a player to your location.
+!summon - Move a player to your location.
+!warpto - Warp to a player.
+!reach - Warp to a player.
+!follow - Warp to a player.
+!gmshop - Open the GM shop.
+!heal - Fully heal your HP/MP.
+!item - Spawn an item into your inventory.
+!drop - Spawn an item onto the ground.
+!level - Set your level.
+!levelpro - Set your level, one by one.
+!setslot - Set amount of inventory slots in all tabs.
+!setstat - Set all primary stats to new value.
+!maxstat - Max out all character stats.
+!maxskill - Max out all job skills.
+!resetskill Set all skill levels to 0.
+!search - Search String.wz.
+!jail - Move a player to the jail.
+!unjail- Free a player from jail.
+!job - Change job of a player.
+!unbug - Unbug self.
+!id - Search in handbook.
+!gachalist - Show gachapon rewards.
+!loot - Loots all items that belong to you.
+!mobskill - Apply a mob skill to all mobs on the map.
+Args: <mob skill id> <skill level>
+
+
+GM Commands:
+!debuff - Put a debuff on all nearby players.
+!fly - Enable/disable fly feature.
+!spawn - Spawn mob(s) on your location.
+!mutemap - Toggle mute players in the map.
+!checkdmg - Show stats and damage of a player.
+!inmap - Show all players in the map.
+!reloadevents - Reload all event data.
+!reloaddrops - Reload all drop data.
+!reloadportals - Reload all portal scripts.
+!reloadmap - Reload the map.
+!reloadshops - Reload popup shops and NPC shops.
+!hpmp - Set HP/MP of a player.
+!maxhpmp - Set base HP/MP of a player.
+!music - Play a song.
+!monitor - Toggle monitored packet logging of a character.
+!monitors - Show all characters being monitored for packet logging.
+!ignore - Toggle ignore a character from auto-ban alerts.
+!ignored - Show all characters being ignored in auto-ban alerts.
+!pos - Show current position and foothold.
+!togglecoupon - Toggle enable/disable a coupon.
+!togglewhitechat - Toggle white GM chat.
+!fame - Set new fame value of a player.
+!givenx - Give NX to a player.
+!givevp - Give vote points to a player.
+!givems - Give mesos to a player.
+!giverp - Give reward points to a player.
+!expeds - Show all ongoing boss expeditions.
+!kill - Kill a player.
+!seed - Drop all seeds inside Henesys PQ.
+!maxenergy - Set dojo energy to max value.
+!killall - Kill all mobs in the map.
+!notice - Send a blue message to everyone on the server.
+!rip - Send a RIP notice.
+!openportal - Open a portal on the map.
+!closeportal - Close a portal.
+!pe - Handle synthesized packets from file, and handle them as if sent from a client.
+!startevent - Start an event on current map.
+!endevent - Close entry for ongoing event.
+!startmapevent - Start a "classic" event on current map.
+!stopmapevent - Stop ongoing "classic" event.
+!online2 - Show all online players.
+!ban - Ban a player.
+!unban - Unban a player.
+!healmap - Heal all HP/MP of all players in the map.
+!healperson - Heal all HP/MP of a player.
+!hurt - Nearly kill a player.
+!killmap - Kill all players in the map.
+!night - Set sky background to black.
+!npc - Spawn an NPC on your location.
+!face - Change face of a player.
+!hair - Change hair of a player.
+!startquest - Start a quest.
+!completequest - Complete an active quest.
+!resetquest - Reset a completed quest.
+!timer - Set timer on a player in current map.
+!timermap - Set timer on all players in current map.
+!timerall Set a server wide timer.
+!warpmap - Warp all characters on current map to a new map.
+!warparea - Warp all nearby players to a new map.
+
+
+SuperGM Commands:
+!servermessage - Set scrolling server message.
+!proitem - Spawn an item with custom stats.
+!seteqstat-Set stats of all equips in inventory.
+!exprate - Set world exp rate.
+!mesorate - Set world meso rate.
+!droprate - Set world drop rate.
+!bossdroprate - Set world boss drop rate.
+!questrate - Set world quest rate.
+!travelrate - Set world travel rate.
+!fishrate - Set fishing rate.
+!itemvac - Loot all drops on the map.
+!forcevac-Loot all drops on the map.
+!zakum - Spawn Zakum on your location.
+!horntail - Spawn Horntail on your location.
+!pinkbean - Spawn Pink Bean on your location.
+!pap - Spawn Papulatus on your location.
+!pianus - Spawn Pianus (R) on your location.
+!cake - Spawn Cake boss with specified HP.
+!playernpc - Spawn a player NPC of an online player.
+!playernpcremove - Remove a "Iv 200" player NPC.
+!pnpc - Spawn a permanent NPC on your location.
+!pnpcremove - Remove a permanent NPC on the map.
+!pmob - Spawn a permanent mob on your location.
+!pmobremove - Remove all permanent mobs of the same type on the map.
+
+
+Developer Commands:
+!debug - Show a debug message.
+!set - Store value in an array, for testing.
+!showpackets - Toggle show received packets in console.
+!showmovelife - Toggle show move life in console.
+!showsessions - Show online sessions.
+!iplist - Show IP of all players.
+
+
+Admin Commands:
+!setgmlevel - Set GM level of a player.
+!warpworld - Warp to a different world.
+!saveall - Save all characters.
+!dcall - Disconnect all players (online or logged in).
+!mapplayers - Show all players on the map.
+!getacc - Show account name of an online player.
+!shutdown - Shut down the server.
+!clearquestcache - Clear all quest cache.
+!clearquest - Clear cache of a quest.
+!supplyratecoupon - Set availability of coupons in Cash Shop.
+!spawnallpnpcs - Spawn player NPCs of all existing players.
+!eraseallpnpcs - Remove all player NPCs.
+!addchannel - Add a new channel to a world.
+!addworld - Add a new world.
+!removechannel - Remove channel from a world.
+!removeworld - Remove a world.
+!devtest - Runs devtest.js. Developer utility - test stuff without restarting the server.
+
+

scripts/npc/2100008.js

@@ -58,8 +58,8 @@ function action(mode, type, selection) {
                     }
                 }
                 if (cm.getChar().getGender() == 1) {
-                    for (var i = 0; i < fface.length; i++) {
-                        pushIfItemExists(facenew, fface[i] + cm.getChar().getFace()
+                    for (var i = 0; i < fface_v.length; i++) {
+                        pushIfItemExists(facenew, fface_v[i] + cm.getChar().getFace()
                             % 1000 - (cm.getChar().getFace()
                                 % 100));
                     }

src/main/java/server/ItemInformationProvider.java

@@ -2063,7 +2063,7 @@ public class ItemInformationProvider {
                 try (ResultSet rs = ps.executeQuery()) {
                     if (rs.next()) {
                         int dropperid = rs.getInt("dropperid");
-                        itemid = getCrystalForLevel(LifeFactory.getMonsterLevel(dropperid) - 1);
+                        itemid = getCrystalForLevel(LifeFactory.getMonsterLevel(dropperid));
                     }
                 }
             }

src/main/java/server/life/MonsterInformationProvider.java

@@ -58,7 +58,7 @@ public class MonsterInformationProvider {
 
     private final Map<Integer, List<MonsterDropEntry>> drops = new HashMap<>();
     private final List<MonsterGlobalDropEntry> globaldrops = new ArrayList<>();
-    private final Map<Integer, List<MonsterGlobalDropEntry>> continentdrops = new HashMap<>();
+    private final Map<Integer, List<MonsterGlobalDropEntry>> continentDrops = new HashMap<>();
 
     private final Map<Integer, List<Integer>> dropsChancePool = new HashMap<>();    // thanks to ronan
     private final Set<Integer> hasNoMultiEquipDrops = new HashSet<>();
@@ -76,23 +76,15 @@ public class MonsterInformationProvider {
         retrieveGlobal();
     }
 
-    public final List<MonsterGlobalDropEntry> getRelevantGlobalDrops(int mapid) {
-        int continentid = mapid / 100000000;
+    public final List<MonsterGlobalDropEntry> getRelevantGlobalDrops(int mapId) {
+        final int continentId = mapId / 100000000;
+        return continentDrops.computeIfAbsent(continentId, this::loadContinentDrops);
+    }
 
-        List<MonsterGlobalDropEntry> contiItems = continentdrops.get(continentid);
-        if (contiItems == null) {   // continent separated global drops found thanks to marcuswoon
-            contiItems = new ArrayList<>();
-
-            for (MonsterGlobalDropEntry e : globaldrops) {
-                if (e.continentid < 0 || e.continentid == continentid) {
-                    contiItems.add(e);
-                }
-            }
-
-            continentdrops.put(continentid, contiItems);
-        }
-
-        return contiItems;
+    private List<MonsterGlobalDropEntry> loadContinentDrops(int continentId) {
+        return globaldrops.stream()
+                .filter(dropEntry -> dropEntry.continentid < 0 || dropEntry.continentid == continentId)
+                .toList();
     }
 
     private void retrieveGlobal() {
@@ -291,7 +283,7 @@ public class MonsterInformationProvider {
         extraMultiEquipDrops.clear();
         dropsChancePool.clear();
         globaldrops.clear();
-        continentdrops.clear();
+        continentDrops.clear();
         retrieveGlobal();
     }
 }

src/main/java/server/maps/MapleMap.java

@@ -751,7 +751,7 @@ public class MapleMap {
         }
 
         final MonsterInformationProvider mi = MonsterInformationProvider.getInstance();
-        final List<MonsterGlobalDropEntry> globalEntry = mi.getRelevantGlobalDrops(this.getId());
+        final List<MonsterGlobalDropEntry> globalEntry = new ArrayList<>(mi.getRelevantGlobalDrops(mapid));
 
         final List<MonsterDropEntry> dropEntry = new ArrayList<>();
         final List<MonsterDropEntry> visibleQuestEntry = new ArrayList<>();

src/main/java/tools/Randomizer.java

@@ -35,6 +35,6 @@ public class Randomizer {
     }
 
     public static int rand(final int lbound, final int ubound) {
-        return (int) ((rand.nextDouble() * (ubound - lbound + 1)) + lbound);
+        return ((int) (rand.nextDouble() * (ubound - lbound + 1))) + lbound;
     }
 }

src/test/java/tools/RandomizerTest.java

@@ -0,0 +1,37 @@
+package tools;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class RandomizerTest {
+
+    @Test
+    void randShouldIncludeEntireRange() {
+        Map<Integer, Integer> rands = new HashMap<>();
+
+        final int rounds = 100_000;
+        for (int i = 0; i < rounds; i++) {
+            int randomValue = Randomizer.rand(-5, 5);
+            rands.compute(randomValue, (k, v) -> v == null ? 0 : v + 1);
+        }
+
+        assertFalse(rands.containsKey(-6));
+        assertTrue(rands.containsKey(-5));
+        assertTrue(rands.containsKey(-4));
+        assertTrue(rands.containsKey(-3));
+        assertTrue(rands.containsKey(-2));
+        assertTrue(rands.containsKey(-1));
+        assertTrue(rands.containsKey(0));
+        assertTrue(rands.containsKey(1));
+        assertTrue(rands.containsKey(2));
+        assertTrue(rands.containsKey(3));
+        assertTrue(rands.containsKey(4));
+        assertTrue(rands.containsKey(5));
+        assertFalse(rands.containsKey(6));
+    }
+}