Add tests for NoteService

src/test/java/service/NoteServiceTest.java

@@ -0,0 +1,142 @@
+package service;
+
+import database.note.NoteDao;
+import model.Note;
+import net.packet.out.ShowNotesPacket;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import testutil.Mocks;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.*;
+import static testutil.AnyValues.daoException;
+import static testutil.AnyValues.string;
+
+class NoteServiceTest {
+
+    @Mock
+    private NoteDao noteDao;
+
+    private NoteService noteService;
+
+    @BeforeEach
+    void reset() {
+        MockitoAnnotations.openMocks(this);
+        this.noteService = new NoteService(noteDao);
+    }
+
+    @Test
+    void sendNormalSuccess() {
+        String message = "message";
+        String from = "from";
+        String to = "to";
+
+        boolean success = noteService.sendNormal(message, from, to);
+
+        assertTrue(success);
+        var noteCaptor = ArgumentCaptor.forClass(Note.class);
+        verify(noteDao).save(noteCaptor.capture());
+        var note = noteCaptor.getValue();
+        assertEquals(message, note.message());
+        assertEquals(from, note.from());
+        assertEquals(to, note.to());
+        assertEquals(0, note.fame());
+    }
+
+    @Test
+    void sendWithFameSuccess() {
+        String message = "fameMessage";
+        String from = "fameFrom";
+        String to = "fameTo";
+
+        boolean success = noteService.sendWithFame(message, from, to);
+
+        assertTrue(success);
+        var noteCaptor = ArgumentCaptor.forClass(Note.class);
+        verify(noteDao).save(noteCaptor.capture());
+        var note = noteCaptor.getValue();
+        assertEquals(message, note.message());
+        assertEquals(from, note.from());
+        assertEquals(to, note.to());
+        assertEquals(1, note.fame());
+    }
+
+    @Test
+    void sendFailure() {
+        doThrow(daoException()).when(noteDao).save(any());
+
+        boolean success = noteService.sendNormal(string(), string(), string());
+
+        assertFalse(success);
+        verify(noteDao).save(any());
+    }
+
+    @Test
+    void showRejectsNull() {
+        assertThrows(IllegalArgumentException.class, () -> noteService.show(null));
+    }
+
+    @Test
+    void showOneNote() {
+        String chrName = "showMeNotes";
+        var chr = Mocks.chr(chrName);
+        when(noteDao.findAllByTo(chrName)).thenReturn(List.of(anyNote()));
+
+        noteService.show(chr);
+
+        verify(chr).sendPacket(any(ShowNotesPacket.class));
+    }
+
+    private Note anyNote() {
+        return new Note(1, "message", "from", "to", 100200300400L, 0);
+    }
+
+    @Test
+    void showZeroNotes_shouldNotSendPacket() {
+        var chr = Mocks.chr("mockChr");
+        when(noteDao.findAllByTo(any())).thenReturn(Collections.emptyList());
+
+        noteService.show(chr);
+
+        verify(chr, never()).sendPacket(any());
+    }
+
+    @Test
+    void showNotesFailure_shouldNotSendPacket() {
+        var chr = Mocks.chr("mockChr");
+        when(noteDao.findAllByTo(any())).thenThrow(daoException());
+
+        noteService.show(chr);
+
+        verify(chr, never()).sendPacket(any());
+    }
+
+    @Test
+    void deleteNoteSuccess() {
+        int noteId = 1056;
+        var note = anyNote();
+        when(noteDao.delete(noteId)).thenReturn(Optional.of(note));
+
+        Optional<Note> deletedNote = noteDao.delete(noteId);
+
+        assertTrue(deletedNote.isPresent());
+        assertEquals(note, deletedNote.get());
+    }
+
+    @Test
+    void deleteNoteFailure() {
+        when(noteDao.delete(anyInt())).thenThrow(daoException());
+
+        Optional<Note> deletedNote = noteService.delete(4382);
+
+        assertTrue(deletedNote.isEmpty());
+    }
+}

src/test/java/testutil/AnyValues.java

@@ -0,0 +1,14 @@
+package testutil;
+
+import database.DaoException;
+
+public class AnyValues {
+
+    public static String string() {
+        return "string";
+    }
+
+    public static DaoException daoException() {
+        return new DaoException(string(), new RuntimeException());
+    }
+}

src/test/java/testutil/Mocks.java

@@ -0,0 +1,19 @@
+package testutil;
+
+import client.Character;
+import org.mockito.Mockito;
+
+import static org.mockito.Mockito.when;
+
+public class Mocks {
+
+    public static Character chr() {
+        return Mockito.mock(Character.class);
+    }
+
+    public static Character chr(String name) {
+        var chr = chr();
+        when(chr.getName()).thenReturn(name);
+        return chr;
+    }
+}