Since 7dee290 a Discord account linked to a staff member opened the
moderator panel for 12 hours on Discord's word alone, with no password and
no 2FA code, though the normal sign-in asks for both every time; and since
b11ae1d the bot took /moderate and /burrow commands from that Discord
account alone. The link outlives a new password and "sign out
everywhere", so a taken-over Discord account was enough to act as the
staff member. The admin dashboard's Discord sign-in (adminDashboardAccess)
skipped its password the same way.
- /mod/discord/callback and /admin/discord/callback no longer sign in:
they keep a pending sign-in for 5 minutes (a Strict cookie) and the page
asks for the linked account's 2FA code (POST .../api/discord/code). Five
wrong codes and it must start again at Discord. The admin one also needs
the account to have 2FA on and not be locked.
- the bot's commands and buttons count only for a staff member with a
panel session that took a code (modpanel.discordBot.commandActor): the
password sign-in, or Discord and a code; not the game's token sign-in. A
new password, signing out everywhere or 2FA turned off end those
sessions (forget), and so the bot's use. Whose Discord it is still keeps
linked staff out of /discord moderation, and lets them close tickets.
Co-Authored-By: Claude Opus 5.5 <[email protected]>