mirror of
https://github.com/burrow-dev/burrow-server.git
synced 2026-11-19 01:27:51 -05:00
fix(ci): pass the security invariants and clear the code-scanning alerts
- Remove package-lock.json: the server uses no npm packages, which the invariants check enforces (no supply chain to attack). - Allow the two hosts the server really calls in .github/allowed-hosts.json: cdn.jsdelivr.net (Twemoji pictures, lib/emoji.js) and vision.googleapis.com (the optional SafeSearch check, lib/image-moderation.js). The github.com mention in lib/emoji.js was only a comment, now reworded. - logText strips line feeds with .replace(/\n/g, ""), the form CodeQL's js/log-injection recognises as a sanitiser. The old [\r\n]+ to a space was just as safe, but not recognised, so every log line using it was flagged (34 alerts on main, 35 on this branch). - /authenticate: the saved sign-in is decided by what the server finds for the refresh token, not by whether the request has one (js/user-controlled-bypass). A token that is not good is still refused with error_code 100. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
d8a9c1f881
commit
ee06e8ca77
5 files changed
+15
-25
No files matched your search
+1
-1
@@ -8,7 +8,7 @@ const {logText} = require("./logtext.js");
|
||||
// pictures of emoji, for the patched client's chat bubbles (gui.ChatBalloon):
|
||||
// the game's font has none, so an emoji typed in chat (with Windows' emoji
|
||||
// panel, say) is drawn as one of these. they are Twemoji's (CC-BY 4.0,
|
||||
// https://github.com/jdecked/twemoji), asked of config.emojiUpstream once
|
||||
// jdecked/twemoji on GitHub), asked of config.emojiUpstream once
|
||||
// each and kept in data/emoji. a name is the emoji's code points in hex,
|
||||
// joined by "-", as Twemoji names its files ("1f600", "1f468-200d-1f469").
|
||||
|
||||
|
||||
Reference in new issue
Block a user