From 45ca7009c8322bed2951409fe16c9ec4415fd423 Mon Sep 17 00:00:00 2001 From: James McDowell Date: Sun, 16 May 2021 10:32:51 +1000 Subject: [PATCH 1/6] Updated to allow a generic rebirth npc id to be passed through and used for rebirthing if it's enabled. --- config.yaml | 1 + scripts/npc/9010021.js | 46 ++----------- scripts/npc/rebirth.js | 66 +++++++++++++++++++ src/main/java/config/ServerConfig.java | 1 + .../channel/handlers/NPCTalkHandler.java | 2 + 5 files changed, 74 insertions(+), 42 deletions(-) create mode 100644 scripts/npc/rebirth.js diff --git a/config.yaml b/config.yaml index 34a13ef794..e3a5fc5f2f 100644 --- a/config.yaml +++ b/config.yaml @@ -319,6 +319,7 @@ server: NAME_CHANGE_COOLDOWN: 2592000000 # (30*24*60*60*1000) Cooldown for name changes, default (GMS) is 30 days. WORLD_TRANSFER_COOLDOWN: 2592000000 # (30*24*60*60*1000) Cooldown for world tranfers, default is same as name change (30 days). INSTANT_NAME_CHANGE: false #Whether or not to wait for server restart to apply name changes. Does on reconnect otherwise (requires queries on every login). + REBIRTH_NPC_ID: 9010021 #ID of the NPC that should be replaced with the rebirth mechanic, if enabled. #Dangling Items/Locks Configuration ITEM_EXPIRE_TIME: 180000 # (3 * 60 * 1000) Time before items start disappearing. Recommended to be set up to 3 minutes. diff --git a/scripts/npc/9010021.js b/scripts/npc/9010021.js index 0abd074218..8899b84e00 100644 --- a/scripts/npc/9010021.js +++ b/scripts/npc/9010021.js @@ -21,47 +21,9 @@ */ /* 9010021 - Wolf Spirit Ryko @author Ronan - */ - var status; - + @author wejrox +*/ function start() { - status = -1; - if (!Packages.config.YamlConfig.config.server.USE_REBIRTH_SYSTEM) { - cm.sendOk("... I came from distant planes to assist the fight against the #rBlack Magician#k. Right now I search my master, have you seen him?"); - cm.dispose(); - return; - } - action(1, 0, 0); -} - -function action(mode, type, selection) { - if (mode == 1) { - status++; - } else { - cm.dispose(); - return; - } - if (status == 0) { - cm.sendNext("Come to me when you want to be reborn again. You currently have a total of #r" + cm.getChar().getReborns() + " #krebirths."); - } else if (status == 1) { - cm.sendSimple("What do you want me to do today: \r\n \r\n #L0##bI want to be rebirthed#l \r\n #L1##bMaybe next time#k#l"); - } else if (status == 2) { - if (selection == 0) { - if (cm.getChar().getLevel() == 200) { - cm.sendYesNo("Are you sure you want to be rebirthed?"); - } else { - cm.sendOk("You are not level 200, please come back when you hit level 200."); - cm.dispose(); - } - } else if (selection == 1) { - cm.sendOk("Ok Bye") - cm.dispose(); - } - } else if (status == 3 && type == 1) { - cm.getChar().executeReborn(); - cm.sendOk("You have now been reborn. That's a total of #r" + cm.getChar().getReborns() + "#k rebirths"); - cm.dispose(); - } - - + cm.sendOk("... I came from distant planes to assist the fight against the #rBlack Magician#k. Right now I search my master, have you seen him?"); + cm.dispose(); } \ No newline at end of file diff --git a/scripts/npc/rebirth.js b/scripts/npc/rebirth.js new file mode 100644 index 0000000000..c32670e46a --- /dev/null +++ b/scripts/npc/rebirth.js @@ -0,0 +1,66 @@ +/* + This file is part of the OdinMS Maple Story Server + Copyright (C) 2008 Patrick Huy + Matthias Butz + Jan Christian Meyer + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as + published by the Free Software Foundation version 3 as published by + the Free Software Foundation. You may not use, modify or distribute + this program under any other version of the GNU Affero General Public + License. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU Affero General Public License for more details. + + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see . +*/ +/* 9010021 - Wolf Spirit Ryko + @author Ronan + @author wejrox +*/ +var status; + +function start() { + status = -1; + if (!Packages.config.YamlConfig.config.server.USE_REBIRTH_SYSTEM) { + cm.sendOk("Rebirths aren't enabled on this server, how did you get here?"); + cm.dispose(); + return; + } + action(1, 0, 0); +} + +function action(mode, type, selection) { + if (mode == 1) { + status++; + } else { + cm.dispose(); + return; + } + if (status == 0) { + cm.sendNext("Come to me when you want to be reborn again. You currently have a total of #r" + cm.getChar().getReborns() + " #krebirths."); + } else if (status == 1) { + cm.sendSimple("What do you want me to do today: \r\n \r\n #L0##bI want to be reborn!#l \r\n #L1##bNothing for now...#k#l"); + } else if (status == 2) { + if (selection == 0) { + if (cm.getChar().getLevel() == 200) { + cm.sendYesNo("Are you sure you want to be reborn?"); + } else { + cm.sendOk("You are not level 200, please come back when you hit level 200."); + cm.dispose(); + } + } else if (selection == 1) { + cm.sendOk("See you soon!") + cm.dispose(); + } + } else if (status == 3 && type == 1) { + cm.getChar().executeReborn(); + cm.sendOk("You have now been reborn. That's a total of #r" + cm.getChar().getReborns() + "#k rebirths"); + cm.dispose(); + } +} \ No newline at end of file diff --git a/src/main/java/config/ServerConfig.java b/src/main/java/config/ServerConfig.java index dbdd9e0a76..5aee568e01 100644 --- a/src/main/java/config/ServerConfig.java +++ b/src/main/java/config/ServerConfig.java @@ -163,6 +163,7 @@ public class ServerConfig { public long NAME_CHANGE_COOLDOWN; public long WORLD_TRANSFER_COOLDOWN=NAME_CHANGE_COOLDOWN;//Cooldown for world tranfers, default is same as name change (30 days). public boolean INSTANT_NAME_CHANGE; + public long REBIRTH_NPC_ID; //Dangling Items/Locks Configuration public int ITEM_EXPIRE_TIME ; diff --git a/src/main/java/net/server/channel/handlers/NPCTalkHandler.java b/src/main/java/net/server/channel/handlers/NPCTalkHandler.java index 71f71c345c..73fec20467 100644 --- a/src/main/java/net/server/channel/handlers/NPCTalkHandler.java +++ b/src/main/java/net/server/channel/handlers/NPCTalkHandler.java @@ -65,6 +65,8 @@ public final class NPCTalkHandler extends AbstractMaplePacketHandler { NPCScriptManager.getInstance().start(c, npc.getId(), "gachapon", null); } else if (npc.getName().endsWith("Maple TV")) { NPCScriptManager.getInstance().start(c, npc.getId(), "mapleTV", null); + } else if (YamlConfig.config.server.USE_REBIRTH_SYSTEM && npc.getId() == YamlConfig.config.server.REBIRTH_NPC_ID) { + NPCScriptManager.getInstance().start(c, npc.getId(), "rebirth", null); } else { boolean hasNpcScript = NPCScriptManager.getInstance().start(c, npc.getId(), oid, null); if (!hasNpcScript) { From cff3d3df567ad711652ec398281035f7bbc56b64 Mon Sep 17 00:00:00 2001 From: James McDowell Date: Sun, 16 May 2021 14:46:38 +1000 Subject: [PATCH 2/6] Added the ability to specify a custom rebirth npc id, which is automatically added to the list of scriptable npcs for overriding. Changed scriptable npcs to use config instead of a constants file, so that users can easily modify them without digging into the code and requiring a rebuild. --- config.yaml | 4 ++ src/main/java/config/ServerConfig.java | 8 ++- .../game/ScriptableNPCConstants.java | 24 --------- .../handlers/PlayerLoggedinHandler.java | 10 +++- src/main/java/tools/MaplePacketCreator.java | 53 +++++++++++-------- 5 files changed, 49 insertions(+), 50 deletions(-) delete mode 100644 src/main/java/constants/game/ScriptableNPCConstants.java diff --git a/config.yaml b/config.yaml index e3a5fc5f2f..73710b8b87 100644 --- a/config.yaml +++ b/config.yaml @@ -461,3 +461,7 @@ server: #Event End Timestamp EVENT_END_TIMESTAMP: 1428897600000 + #Any NPC ids that should search for a js override script (useful if they already have wz entries since otherwise they're ignored). + NPCS_SCRIPTABLE: + #- 9200000 # Cody + - 9001105 # Grandpa moon bunny diff --git a/src/main/java/config/ServerConfig.java b/src/main/java/config/ServerConfig.java index 5aee568e01..7d5372d373 100644 --- a/src/main/java/config/ServerConfig.java +++ b/src/main/java/config/ServerConfig.java @@ -1,5 +1,9 @@ package config; +import tools.Pair; + +import java.util.*; + public class ServerConfig { //Thread Tracker Configuration public boolean USE_THREAD_TRACKER; @@ -163,7 +167,7 @@ public class ServerConfig { public long NAME_CHANGE_COOLDOWN; public long WORLD_TRANSFER_COOLDOWN=NAME_CHANGE_COOLDOWN;//Cooldown for world tranfers, default is same as name change (30 days). public boolean INSTANT_NAME_CHANGE; - public long REBIRTH_NPC_ID; + public int REBIRTH_NPC_ID; //Dangling Items/Locks Configuration public int ITEM_EXPIRE_TIME ; @@ -305,4 +309,6 @@ public class ServerConfig { //Event End Timestamp public long EVENT_END_TIMESTAMP; + //Custom NPC overrides. NPC ID to Name pair. + public List NPCS_SCRIPTABLE = new ArrayList<>(); } diff --git a/src/main/java/constants/game/ScriptableNPCConstants.java b/src/main/java/constants/game/ScriptableNPCConstants.java deleted file mode 100644 index df8a255cf9..0000000000 --- a/src/main/java/constants/game/ScriptableNPCConstants.java +++ /dev/null @@ -1,24 +0,0 @@ -package constants.game; - -/** - * @brief ScriptableNPCConstants - * @author GabrielSin - * @date 16/09/2018 - * - * Adaptations to use Pair and Set, in order to suit a one-packet marshall. - * Adapted by Ronan - */ - -import java.util.HashSet; -import java.util.Set; -import tools.Pair; - -public class ScriptableNPCConstants { - - public static final Set> SCRIPTABLE_NPCS = new HashSet>(){{ - //add(new Pair<>(9200000, "Cody")); - add(new Pair<>(9001105, "Grandpa Moon Bunny")); - }}; - -} - \ No newline at end of file diff --git a/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java b/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java index 4db6a00253..d0d18c88e7 100644 --- a/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java +++ b/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java @@ -26,7 +26,6 @@ import client.inventory.*; import client.keybind.MapleKeyBinding; import config.YamlConfig; import constants.game.GameConstants; -import constants.game.ScriptableNPCConstants; import net.AbstractMaplePacketHandler; import net.server.PlayerBuffValueHolder; import net.server.Server; @@ -409,7 +408,14 @@ public final class PlayerLoggedinHandler extends AbstractMaplePacketHandler { } if (YamlConfig.config.server.USE_NPCS_SCRIPTABLE) { - c.announce(MaplePacketCreator.setNPCScriptable(ScriptableNPCConstants.SCRIPTABLE_NPCS)); + List npcsIds = YamlConfig.config.server.NPCS_SCRIPTABLE; + + // Any npc be specified as the rebirth npc. Allow the npc to use custom scripts explicitly. + if (YamlConfig.config.server.USE_REBIRTH_SYSTEM) { + npcsIds.add(YamlConfig.config.server.REBIRTH_NPC_ID); + } + + c.announce(MaplePacketCreator.setNPCScriptable(YamlConfig.config.server.NPCS_SCRIPTABLE)); } if(newcomer) player.setLoginTime(System.currentTimeMillis()); diff --git a/src/main/java/tools/MaplePacketCreator.java b/src/main/java/tools/MaplePacketCreator.java index 453561979c..1bb4ccf090 100644 --- a/src/main/java/tools/MaplePacketCreator.java +++ b/src/main/java/tools/MaplePacketCreator.java @@ -8318,17 +8318,24 @@ public class MaplePacketCreator { mplew.writeInt(transition); return mplew.getPacket(); } - - public static byte[] setNPCScriptable(Set> scriptNpcDescriptions) { // thanks to GabrielSin + + /** + * Makes the NPCs provided set as scriptable, informing the client to search for js scripts for these NPCs even + * if they already have entries within the wz files. + * + * @param scriptableNpcIds Ids of npcs to enable scripts for. + * @return a packet which makes the npc's provided scriptable. + */ + public static byte[] setNPCScriptable(List scriptableNpcIds) { // thanks to GabrielSin MaplePacketLittleEndianWriter mplew = new MaplePacketLittleEndianWriter(); mplew.writeShort(SendOpcode.SET_NPC_SCRIPTABLE.getValue()); - mplew.write(scriptNpcDescriptions.size()); - for (Pair p : scriptNpcDescriptions) { - mplew.writeInt(p.getLeft()); - mplew.writeMapleAsciiString(p.getRight()); + mplew.write(scriptableNpcIds.size()); + scriptableNpcIds.forEach(id -> { + mplew.writeInt(id); + mplew.writeMapleAsciiString("NPC " + id); // The client needs a name for the npc, but it doesn't seem to do anything. mplew.writeInt(0); // start time mplew.writeInt(Integer.MAX_VALUE); // end time - } + }); return mplew.getPacket(); } @@ -8374,17 +8381,17 @@ public class MaplePacketCreator { final MaplePacketLittleEndianWriter mplew = new MaplePacketLittleEndianWriter(); mplew.writeShort(SendOpcode.TOURNAMENT_SET_PRIZE.getValue()); - //0 = "You have failed the set the prize. Please check the item number again." - //1 = "You have successfully set the prize." - mplew.write(bSetPrize); - - mplew.write(bHasPrize); - - if(bHasPrize != 0) - { - mplew.writeInt(nItemID1); - mplew.writeInt(nItemID2); - } + //0 = "You have failed the set the prize. Please check the item number again." + //1 = "You have successfully set the prize." + mplew.write(bSetPrize); + + mplew.write(bHasPrize); + + if(bHasPrize != 0) + { + mplew.writeInt(nItemID1); + mplew.writeInt(nItemID2); + } return mplew.getPacket(); } @@ -8393,11 +8400,11 @@ public class MaplePacketCreator { final MaplePacketLittleEndianWriter mplew = new MaplePacketLittleEndianWriter(); mplew.writeShort(SendOpcode.TOURNAMENT_UEW.getValue()); - //Is this a bitflag o.o ? - //2 = "You have reached the finals by default." - //4 = "You have reached the semifinals by default." - //8 or 16 = "You have reached the round of %n by default." | Encodes nState as %n ?! - mplew.write(nState); + //Is this a bitflag o.o ? + //2 = "You have reached the finals by default." + //4 = "You have reached the semifinals by default." + //8 or 16 = "You have reached the round of %n by default." | Encodes nState as %n ?! + mplew.write(nState); return mplew.getPacket(); } From 0345ce844e16df6b753c7bcdd91da5125e69dfb4 Mon Sep 17 00:00:00 2001 From: James McDowell Date: Sun, 16 May 2021 14:51:54 +1000 Subject: [PATCH 3/6] Removed unnecessary import --- src/main/java/config/ServerConfig.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/main/java/config/ServerConfig.java b/src/main/java/config/ServerConfig.java index 7d5372d373..da05372eba 100644 --- a/src/main/java/config/ServerConfig.java +++ b/src/main/java/config/ServerConfig.java @@ -1,7 +1,5 @@ package config; -import tools.Pair; - import java.util.*; public class ServerConfig { From 9128329d37fda178605a2d6f254f98a9a897c594 Mon Sep 17 00:00:00 2001 From: James McDowell Date: Thu, 20 May 2021 19:16:22 +1000 Subject: [PATCH 4/6] Swapped from list to set to prevent duplicates Use a set instead, clone instead of adding directly to the list. --- src/main/java/config/ServerConfig.java | 2 +- .../net/server/channel/handlers/PlayerLoggedinHandler.java | 6 ++++-- src/main/java/tools/MaplePacketCreator.java | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/config/ServerConfig.java b/src/main/java/config/ServerConfig.java index da05372eba..7095bce226 100644 --- a/src/main/java/config/ServerConfig.java +++ b/src/main/java/config/ServerConfig.java @@ -307,6 +307,6 @@ public class ServerConfig { //Event End Timestamp public long EVENT_END_TIMESTAMP; - //Custom NPC overrides. NPC ID to Name pair. + //Custom NPC overrides. List of NPC IDs. public List NPCS_SCRIPTABLE = new ArrayList<>(); } diff --git a/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java b/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java index d0d18c88e7..f5ec11e317 100644 --- a/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java +++ b/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java @@ -408,14 +408,16 @@ public final class PlayerLoggedinHandler extends AbstractMaplePacketHandler { } if (YamlConfig.config.server.USE_NPCS_SCRIPTABLE) { - List npcsIds = YamlConfig.config.server.NPCS_SCRIPTABLE; + + // Create a set to remove duplicate entries if they exist. + Set npcsIds = new HashSet<>(YamlConfig.config.server.NPCS_SCRIPTABLE); // Any npc be specified as the rebirth npc. Allow the npc to use custom scripts explicitly. if (YamlConfig.config.server.USE_REBIRTH_SYSTEM) { npcsIds.add(YamlConfig.config.server.REBIRTH_NPC_ID); } - c.announce(MaplePacketCreator.setNPCScriptable(YamlConfig.config.server.NPCS_SCRIPTABLE)); + c.announce(MaplePacketCreator.setNPCScriptable(npcsIds)); } if(newcomer) player.setLoginTime(System.currentTimeMillis()); diff --git a/src/main/java/tools/MaplePacketCreator.java b/src/main/java/tools/MaplePacketCreator.java index 1bb4ccf090..d7f259eda7 100644 --- a/src/main/java/tools/MaplePacketCreator.java +++ b/src/main/java/tools/MaplePacketCreator.java @@ -8326,7 +8326,7 @@ public class MaplePacketCreator { * @param scriptableNpcIds Ids of npcs to enable scripts for. * @return a packet which makes the npc's provided scriptable. */ - public static byte[] setNPCScriptable(List scriptableNpcIds) { // thanks to GabrielSin + public static byte[] setNPCScriptable(Set scriptableNpcIds) { // thanks to GabrielSin MaplePacketLittleEndianWriter mplew = new MaplePacketLittleEndianWriter(); mplew.writeShort(SendOpcode.SET_NPC_SCRIPTABLE.getValue()); mplew.write(scriptableNpcIds.size()); From e967294eb9a1dd4beb58228b7521ddf231d01a53 Mon Sep 17 00:00:00 2001 From: James McDowell Date: Wed, 26 May 2021 19:41:27 +1000 Subject: [PATCH 5/6] Add back in NPC conversation names The names of the npc conversations were useful for context. Added them back in. --- config.yaml | 4 ++-- src/main/java/config/ServerConfig.java | 2 +- .../channel/handlers/PlayerLoggedinHandler.java | 14 ++++++++++---- src/main/java/tools/MaplePacketCreator.java | 7 ++++--- 4 files changed, 17 insertions(+), 10 deletions(-) diff --git a/config.yaml b/config.yaml index 73710b8b87..54d43f32bf 100644 --- a/config.yaml +++ b/config.yaml @@ -463,5 +463,5 @@ server: #Any NPC ids that should search for a js override script (useful if they already have wz entries since otherwise they're ignored). NPCS_SCRIPTABLE: - #- 9200000 # Cody - - 9001105 # Grandpa moon bunny + #9200000: Talk to Cody # Cody + 9001105: Rescue Gaga! # Grandpa moon bunny diff --git a/src/main/java/config/ServerConfig.java b/src/main/java/config/ServerConfig.java index 7095bce226..34beaea4df 100644 --- a/src/main/java/config/ServerConfig.java +++ b/src/main/java/config/ServerConfig.java @@ -308,5 +308,5 @@ public class ServerConfig { public long EVENT_END_TIMESTAMP; //Custom NPC overrides. List of NPC IDs. - public List NPCS_SCRIPTABLE = new ArrayList<>(); + public Map NPCS_SCRIPTABLE = new HashMap<>(); } diff --git a/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java b/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java index f5ec11e317..75c2d12958 100644 --- a/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java +++ b/src/main/java/net/server/channel/handlers/PlayerLoggedinHandler.java @@ -54,6 +54,7 @@ import java.sql.ResultSet; import java.sql.SQLException; import java.util.*; import java.util.Map.Entry; +import java.util.stream.Collectors; public final class PlayerLoggedinHandler extends AbstractMaplePacketHandler { @@ -406,15 +407,20 @@ public final class PlayerLoggedinHandler extends AbstractMaplePacketHandler { eim.registerPlayer(player); } } - + + // Tell the client to use the custom scripts available for the NPCs provided, instead of the WZ entries. if (YamlConfig.config.server.USE_NPCS_SCRIPTABLE) { - // Create a set to remove duplicate entries if they exist. - Set npcsIds = new HashSet<>(YamlConfig.config.server.NPCS_SCRIPTABLE); + // Create a copy to prevent always adding entries to the server's list. + Map npcsIds = YamlConfig.config.server.NPCS_SCRIPTABLE + .entrySet().stream().collect(Collectors.toMap( + entry -> Integer.parseInt(entry.getKey()), + Entry::getValue + )); // Any npc be specified as the rebirth npc. Allow the npc to use custom scripts explicitly. if (YamlConfig.config.server.USE_REBIRTH_SYSTEM) { - npcsIds.add(YamlConfig.config.server.REBIRTH_NPC_ID); + npcsIds.put(YamlConfig.config.server.REBIRTH_NPC_ID, "Rebirth"); } c.announce(MaplePacketCreator.setNPCScriptable(npcsIds)); diff --git a/src/main/java/tools/MaplePacketCreator.java b/src/main/java/tools/MaplePacketCreator.java index d7f259eda7..50ee148ad7 100644 --- a/src/main/java/tools/MaplePacketCreator.java +++ b/src/main/java/tools/MaplePacketCreator.java @@ -8326,13 +8326,14 @@ public class MaplePacketCreator { * @param scriptableNpcIds Ids of npcs to enable scripts for. * @return a packet which makes the npc's provided scriptable. */ - public static byte[] setNPCScriptable(Set scriptableNpcIds) { // thanks to GabrielSin + public static byte[] setNPCScriptable(Map scriptableNpcIds) { // thanks to GabrielSin MaplePacketLittleEndianWriter mplew = new MaplePacketLittleEndianWriter(); mplew.writeShort(SendOpcode.SET_NPC_SCRIPTABLE.getValue()); mplew.write(scriptableNpcIds.size()); - scriptableNpcIds.forEach(id -> { + scriptableNpcIds.forEach((id, name) -> { mplew.writeInt(id); - mplew.writeMapleAsciiString("NPC " + id); // The client needs a name for the npc, but it doesn't seem to do anything. + // The client needs a name for the npc conversation, which is displayed under etc when the npc has a quest available. + mplew.writeMapleAsciiString(name); mplew.writeInt(0); // start time mplew.writeInt(Integer.MAX_VALUE); // end time }); From 136ea68ab379798f914126730242dd9208f33197 Mon Sep 17 00:00:00 2001 From: James McDowell Date: Wed, 26 May 2021 19:45:58 +1000 Subject: [PATCH 6/6] Updated the rebirth NPC to use GraalJS --- scripts/npc/rebirth.js | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/scripts/npc/rebirth.js b/scripts/npc/rebirth.js index c32670e46a..72d2a5f8a6 100644 --- a/scripts/npc/rebirth.js +++ b/scripts/npc/rebirth.js @@ -19,7 +19,7 @@ You should have received a copy of the GNU Affero General Public License along with this program. If not, see . */ -/* 9010021 - Wolf Spirit Ryko +/* Rebirth NPC @author Ronan @author wejrox */ @@ -27,7 +27,8 @@ var status; function start() { status = -1; - if (!Packages.config.YamlConfig.config.server.USE_REBIRTH_SYSTEM) { + const YamlConfig = Java.type('config.YamlConfig'); + if (!YamlConfig.config.server.USE_REBIRTH_SYSTEM) { cm.sendOk("Rebirths aren't enabled on this server, how did you get here?"); cm.dispose(); return; @@ -36,29 +37,29 @@ function start() { } function action(mode, type, selection) { - if (mode == 1) { + if (mode === 1) { status++; } else { cm.dispose(); return; } - if (status == 0) { + if (status === 0) { cm.sendNext("Come to me when you want to be reborn again. You currently have a total of #r" + cm.getChar().getReborns() + " #krebirths."); - } else if (status == 1) { + } else if (status === 1) { cm.sendSimple("What do you want me to do today: \r\n \r\n #L0##bI want to be reborn!#l \r\n #L1##bNothing for now...#k#l"); - } else if (status == 2) { - if (selection == 0) { - if (cm.getChar().getLevel() == 200) { + } else if (status === 2) { + if (selection === 0) { + if (cm.getChar().getLevel() === 200) { cm.sendYesNo("Are you sure you want to be reborn?"); } else { cm.sendOk("You are not level 200, please come back when you hit level 200."); cm.dispose(); } - } else if (selection == 1) { + } else if (selection === 1) { cm.sendOk("See you soon!") cm.dispose(); } - } else if (status == 3 && type == 1) { + } else if (status === 3 && type === 1) { cm.getChar().executeReborn(); cm.sendOk("You have now been reborn. That's a total of #r" + cm.getChar().getReborns() + "#k rebirths"); cm.dispose();