Normalize credit comments

2019-05-26 15:17:53 -03:00
parent bb80441af0
commit e02ede58da
52 changed files with 76 additions and 63 deletions
--- a/src/client/MapleCharacter.java
+++ b/src/client/MapleCharacter.java
@@ -2153,7 +2153,7 @@ public class MapleCharacter extends AbstractMapleCharacterObject {
    
    public static boolean deleteCharFromDB(MapleCharacter player, int senderAccId) {
            int cid = player.getId();
-            if(!Server.getInstance().haveCharacterEntry(senderAccId, cid)) {    // thanks zera (EpiphanyMS) for pointing a critical exploit with non-authored character deletion request
+            if(!Server.getInstance().haveCharacterEntry(senderAccId, cid)) {    // thanks zera (EpiphanyMS) for pointing a critical exploit with non-authed character deletion request
                    return false;
            }
            
@@ -3156,7 +3156,7 @@ public class MapleCharacter extends AbstractMapleCharacterObject {
        }
    }
    
-    public boolean canHoldMeso(int gain) {  // thanks lucasziron found pointing out a need to check space availability for mesos on player transactions
+    public boolean canHoldMeso(int gain) {  // thanks lucasziron for pointing out a need to check space availability for mesos on player transactions
        long nextMeso = (long) meso.get() + gain;
        return nextMeso <= Integer.MAX_VALUE;
    }
@@ -9599,7 +9599,7 @@ public class MapleCharacter extends AbstractMapleCharacterObject {
            if (!mquest.isSameDayRepeatable() && !MapleQuest.isExploitableQuest(questid)) {
                awardQuestPoint(ServerConstants.QUEST_POINT_PER_QUEST_COMPLETE);
            }
-            quest.setCompleted(quest.getCompleted() + 1);   // count quest completed Jayd's idea
+            quest.setCompleted(quest.getCompleted() + 1);   // Jayd's idea - count quest completed
            
            announce(MaplePacketCreator.completeQuest(questid, quest.getCompletionTime()));
        } else if (quest.getStatus().equals(MapleQuestStatus.Status.NOT_STARTED)) {
--- a/src/client/MapleMount.java
+++ b/src/client/MapleMount.java
@@ -22,7 +22,7 @@
 package client;

 /**
- * @author PurpleMadness Patrick :O
+ * @author PurpleMadness (Patrick) :O
 */
 public class MapleMount {
    private int itemid;
--- a/src/client/inventory/Equip.java
+++ b/src/client/inventory/Equip.java
@@ -309,7 +309,7 @@ public class Equip extends Item {
    }
    
    private boolean isNotWeaponAffinity(StatUpgrade name) {
-        // WATK/MATK expected gains lessens outside of weapon affinity (physical/magic): Vcoc's idea
+        // Vcoc's idea - WATK/MATK expected gains lessens outside of weapon affinity (physical/magic)
        
        if (ItemConstants.isWeapon(this.getItemId())) {
            if (name.equals(StatUpgrade.incPAD)) {
--- a/src/client/inventory/manipulator/MapleInventoryManipulator.java
+++ b/src/client/inventory/manipulator/MapleInventoryManipulator.java
@@ -48,7 +48,7 @@ import tools.MaplePacketCreator;
 /**
 *
 * @author Matze
- * @author Ronan - improved check space feature & removed redundant object calls
+ * @author Ronan - improved check space feature and removed redundant object calls
 */
 public class MapleInventoryManipulator {

@@ -427,7 +427,7 @@ public class MapleInventoryManipulator {
            announceModifyInventory(c, item, fromDrop, allowZero);
        } else {
            int petid = item.getPetId();
-            if (petid > -1) { // thanks Vcoc for finding a d/c issue with equipped pets & pets remaining on DB here
+            if (petid > -1) { // thanks Vcoc for finding a d/c issue with equipped pets and pets remaining on DB here
                int petIdx = chr.getPetIndex(petid);
                if(petIdx > -1) {
                    MaplePet pet = chr.getPet(petIdx);
--- a/src/client/processor/FredrickProcessor.java
+++ b/src/client/processor/FredrickProcessor.java
@@ -50,7 +50,7 @@ import tools.Pair;

 /**
 *
- * @author RonanLana - synchronization of Fredrick modules & operation results
+ * @author RonanLana - synchronization of Fredrick modules and operation results
 */
 public class FredrickProcessor {
    
--- a/src/constants/EquipSlot.java
+++ b/src/constants/EquipSlot.java
@@ -2,7 +2,7 @@ package constants;

 /**
 *
- * @author The Spookster
+ * @author The Spookster (The Real Spookster)
 */
 public enum EquipSlot {

--- a/src/constants/ServerConstants.java
+++ b/src/constants/ServerConstants.java
@@ -104,7 +104,7 @@ public class ServerConstants {
    public static final boolean USE_ERASE_UNTRADEABLE_DROP = true;  //Forces flagged untradeable items to disappear when dropped.
    public static final boolean USE_ERASE_PET_ON_EXPIRATION = false;//Forces pets to be removed from inventory when expire time comes, rather than converting it to a doll.
    public static final boolean USE_BUFF_MOST_SIGNIFICANT = true;   //When applying buffs, the player will stick with the highest stat boost among the listed, rather than overwriting stats.
-    public static final boolean USE_BUFF_EVERLASTING = false;       //Every applied buff on players holds expiration time so high it'd be considered permanent. Suggestion thanks to Vcoc.
+    public static final boolean USE_BUFF_EVERLASTING = false;       //Every applied buff on players holds expiration time so high it'd be considered permanent. Thanks Vcoc for this suggestion.
    public static final boolean USE_MULTIPLE_SAME_EQUIP_DROP = true;//Enables multiple drops by mobs of the same equipment, number of possible drops based on the quantities provided at the drop data.
    public static final boolean USE_BANISHABLE_TOWN_SCROLL = true;  //Enables town scrolls to act as if it's a "player banish", rendering the antibanish scroll effect available.
    public static final boolean USE_ENABLE_FULL_RESPAWN = true;     //At respawn task, always respawn missing mobs when they're available. Spawn count doesn't depend on how many players are currently there.
@@ -202,9 +202,9 @@ public class ServerConstants {
    public static final boolean USE_ULTRA_THREE_SNAILS = true;  //Massive damage on shell toss.
    
    //Other Skills Configuration
-    public static final boolean USE_FULL_ARAN_SKILLSET = false; //Enables starter availability to all Aran job skills. Suggestion thanks to Masterrulax.
+    public static final boolean USE_FULL_ARAN_SKILLSET = false; //Enables starter availability to all Aran job skills. Thanks Masterrulax for this suggestion.
    public static final boolean USE_FAST_REUSE_HERO_WILL = true;//Greatly reduce cooldown on Hero's Will.
-    public static final boolean USE_ANTI_IMMUNITY_CRASH = true; //Crash skills additionally removes the mob's invincibility buffs. Suggestion thanks to Celestial.
+    public static final boolean USE_ANTI_IMMUNITY_CRASH = true; //Crash skills additionally removes the mob's invincibility buffs. Thanks Celestial for this suggestion.
    public static final boolean USE_UNDISPEL_HOLY_SHIELD = true;//Holy shield buff also prevents players from suffering dispel from mobs.
    
    //Character Configuration
--- a/src/net/mina/MaplePacketDecoder.java
+++ b/src/net/mina/MaplePacketDecoder.java
@@ -75,7 +75,7 @@ public class MaplePacketDecoder extends CumulativeProtocolDecoder {
            rcvdCrypto.crypt(decryptedPacket);
            MapleCustomEncryption.decryptData(decryptedPacket);
            out.write(decryptedPacket);
-            if (ServerConstants.USE_DEBUG_SHOW_PACKET){ // packet traffic log: Atoot's idea, applied using auto-identation thanks to lrenex
+            if (ServerConstants.USE_DEBUG_SHOW_PACKET){ // Atoot's idea: packet traffic log, applied using auto-identation thanks to lrenex
                int packetLen = decryptedPacket.length;
                int pHeader = readFirstShort(decryptedPacket);
                String pHeaderStr = Integer.toHexString(pHeader).toUpperCase();
--- a/src/net/server/channel/handlers/MesoDropHandler.java
+++ b/src/net/server/channel/handlers/MesoDropHandler.java
@@ -43,7 +43,7 @@ public final class MesoDropHandler extends AbstractMaplePacketHandler {
            slea.skip(4);
            int meso = slea.readInt();

-            if (c.tryacquireClient()) {     // thanks imbee for noticing players not being able to throw mesos too fast, dampening gameplay of some classes
+            if (c.tryacquireClient()) {     // thanks imbee for noticing players not being able to throw mesos too fast
                try {
                    if (meso <= player.getMeso() && meso > 9 && meso < 50001) {
                        player.gainMeso(-meso, false, true, false);
--- a/src/net/server/channel/handlers/MobDamageMobFriendlyHandler.java
+++ b/src/net/server/channel/handlers/MobDamageMobFriendlyHandler.java
@@ -31,7 +31,7 @@ import client.MapleClient;

 /**
 *
- * @author Xotic & BubblesDev
+ * @author Xotic (XoticStory) & BubblesDev
 */

 public final class MobDamageMobFriendlyHandler extends AbstractMaplePacketHandler {
--- a/src/net/server/channel/handlers/MonsterCarnivalHandler.java
+++ b/src/net/server/channel/handlers/MonsterCarnivalHandler.java
@@ -40,7 +40,7 @@ import tools.data.input.SeekableLittleEndianAccessor;


 /**
-    *@author Drago/Dragohe4rt
+    *@author Drago (Dragohe4rt)
 */

 public final class MonsterCarnivalHandler extends AbstractMaplePacketHandler {
--- a/src/net/server/channel/handlers/PlayerInteractionHandler.java
+++ b/src/net/server/channel/handlers/PlayerInteractionHandler.java
@@ -53,7 +53,7 @@ import java.sql.SQLException;
 /**
 *
 * @author Matze
- * @author Ronan - concurrency safety & reviewed minigames
+ * @author Ronan - concurrency safety and reviewed minigames
 */
 public final class PlayerInteractionHandler extends AbstractMaplePacketHandler {
    public enum Action {
--- a/src/net/server/channel/handlers/RemoteStoreHandler.java
+++ b/src/net/server/channel/handlers/RemoteStoreHandler.java
@@ -31,7 +31,7 @@ import tools.data.input.SeekableLittleEndianAccessor;

 /**
 *
- * @author kevintjuh93 :3
+ * @author kevintjuh93 - :3
 */
 public class RemoteStoreHandler extends AbstractMaplePacketHandler {
    @Override
--- a/src/net/server/channel/handlers/RingActionHandler.java
+++ b/src/net/server/channel/handlers/RingActionHandler.java
@@ -48,7 +48,7 @@ import tools.packets.Wedding;
 /**
 * @author Jvlaple
 * @author Ronan - major overhaul on Ring handling mechanics
- * @author Drago/Dragohe4rt - on Wishlist
+ * @author Drago (Dragohe4rt) - on Wishlist
 */
 public final class RingActionHandler extends AbstractMaplePacketHandler {
    private static int getBoxId(int useItemId) {
@@ -466,7 +466,7 @@ public final class RingActionHandler extends AbstractMaplePacketHandler {
                
            case 9: 
                try {
-                    // By Drago/Dragohe4rt
+                    // By -- Drago (Dragohe4rt)
                    // Groom and Bride's Wishlist

                    MapleCharacter player = c.getPlayer();
--- a/src/net/server/channel/handlers/SummonDamageHandler.java
+++ b/src/net/server/channel/handlers/SummonDamageHandler.java
@@ -76,7 +76,7 @@ public final class SummonDamageHandler extends AbstractDealDamageHandler {
        List<SummonAttackEntry> allDamage = new ArrayList<>();
        byte direction = slea.readByte();
        int numAttacked = slea.readByte();
-        slea.skip(8); //Thanks Gerald :D, I failed lol (mob x,y and summon x,y)
+        slea.skip(8); // I failed lol (mob x,y and summon x,y), Thanks Gerald
        for (int x = 0; x < numAttacked; x++) {
            int monsterOid = slea.readInt(); // attacked oid
            slea.skip(18);
--- a/src/net/server/channel/handlers/UseCashItemHandler.java
+++ b/src/net/server/channel/handlers/UseCashItemHandler.java
@@ -317,7 +317,7 @@ public final class UseCashItemHandler extends AbstractMaplePacketHandler {
                    break;
            }
            remove(c, position, itemId);
-        } else if (itemType == 508) {   // graduation banner, thanks to tmskdl12. Also, thanks ratency for first pointing lack of Kite handling
+        } else if (itemType == 508) {   // thanks tmskdl12 for graduation banner; thanks ratency for first pointing lack of Kite handling
            MapleKite kite = new MapleKite(player, slea.readMapleAsciiString(), itemId);
            
            if (!GameConstants.isFreeMarketRoom(player.getMapId())) {
--- a/src/net/server/channel/handlers/UseGachaExpHandler.java
+++ b/src/net/server/channel/handlers/UseGachaExpHandler.java
@@ -30,7 +30,9 @@ import tools.data.input.SeekableLittleEndianAccessor;

 /**
 *
- * @author kevintjuh93; modified by Ronan
+ * @author kevintjuh93
+ * 
+ * Modified by -- Ronan - concurrency protection
 */
 public class UseGachaExpHandler extends AbstractMaplePacketHandler {
    
--- a/src/net/server/channel/handlers/UseSolomonHandler.java
+++ b/src/net/server/channel/handlers/UseSolomonHandler.java
@@ -34,7 +34,9 @@ import tools.data.input.SeekableLittleEndianAccessor;

 /**
 *
- * @author XoticStory; modified by kevintjuh93, Ronan
+ * @author XoticStory
+ * 
+ * Modified by -- kevintjuh93, Ronan
 */
 public final class UseSolomonHandler extends AbstractMaplePacketHandler {

--- a/src/net/server/channel/handlers/WeddingHandler.java
+++ b/src/net/server/channel/handlers/WeddingHandler.java
@@ -26,7 +26,7 @@ import java.util.List;

 /**
 *
- * @author By Drago/Dragohe4rt
+ * @author Drago (Dragohe4rt)
 */
 public final class WeddingHandler extends AbstractMaplePacketHandler {
    
--- a/src/net/server/world/World.java
+++ b/src/net/server/world/World.java
@@ -100,7 +100,7 @@ import net.server.coordinator.MaplePartySearchCoordinator;
 /**
 *
 * @author kevintjuh93
- * @author Ronan - thread-oriented world schedules, guild queue, marriages & party chars
+ * @author Ronan - thread-oriented (world schedules + guild queue + marriages + party chars)
 */
 public class World {

--- a/src/scripting/npc/NPCConversationManager.java
+++ b/src/scripting/npc/NPCConversationManager.java
@@ -622,7 +622,7 @@ public class NPCConversationManager extends AbstractPlayerInteraction {
                return sbe != SkillBookEntry.UNAVAILABLE ? "    Obtainable through #rquestline#k." : "";
        }
        
-        // By Drago/Dragohe4rt CPQ + WED
+        // (CPQ + WED wishlist) by -- Drago (Dragohe4rt)
        public int cpqCalcAvgLvl(int map) {
            int num = 0;
            int avg = 0;
--- a/src/server/MapleItemInformationProvider.java
+++ b/src/server/MapleItemInformationProvider.java
@@ -910,10 +910,14 @@ public class MapleItemInformationProvider {
            }
        }
    }
-
+    
+    /*
+        Issue with clean slate found thanks to Masterrulax
+        Vicious added in the clean slate check thanks to Crypter (CrypterDEV)
+    */
    public boolean canUseCleanSlate(Equip nEquip) {
        Map<String, Integer> eqstats = this.getEquipStats(nEquip.getItemId());
-        return ServerConstants.USE_ENHANCED_CLNSLATE || nEquip.getUpgradeSlots() < (byte) (eqstats.get("tuc") + nEquip.getVicious());  // issue with clean slate found thanks to Masterrulax, vicious added in the check thanks to Crypter (CrypterDEV)
+        return ServerConstants.USE_ENHANCED_CLNSLATE || nEquip.getUpgradeSlots() < (byte) (eqstats.get("tuc") + nEquip.getVicious());
    }

    public Item scrollEquipWithId(Item equip, int scrollId, boolean usingWhiteScroll, int vegaItemId, boolean isGM) {
@@ -1522,7 +1526,7 @@ public class MapleItemInformationProvider {
        }
    }

-    public Pair<Integer, List<RewardItem>> getItemReward(int itemId) {//Thanks Celino, used some stuffs :)
+    public Pair<Integer, List<RewardItem>> getItemReward(int itemId) {//Thanks Celino - used some stuffs :)
        if (rewardCache.containsKey(itemId)) {
            return rewardCache.get(itemId);
        }
--- a/src/server/MapleTrade.java
+++ b/src/server/MapleTrade.java
@@ -44,7 +44,7 @@ import tools.Pair;
 /**
 *
 * @author Matze
- * @author Ronan - concurrency safety & check available slots & trade results
+ * @author Ronan - concurrency safety + check available slots + trade results
 */
 public class MapleTrade {
    
--- a/src/server/maps/MapleTVEffect.java
+++ b/src/server/maps/MapleTVEffect.java
@@ -29,7 +29,7 @@ import tools.MaplePacketCreator;

 /*
 * MapleTVEffect
- * @author MrXotic
+ * @author MrXotic (XoticStory)
 * @author Ronan - made MapleTV mechanics synchronous
 */
 public class MapleTVEffect {
--- a/src/server/partyquest/MapleCarnivalFactory.java
+++ b/src/server/partyquest/MapleCarnivalFactory.java
@@ -14,7 +14,7 @@ import provider.MapleDataTool;
 import server.life.MobSkill;

 /**
-    *@author Drago/Dragohe4rt
+    *@author Drago (Dragohe4rt)
 */
 public class MapleCarnivalFactory {

--- a/src/server/partyquest/MonsterCarnival.java
+++ b/src/server/partyquest/MonsterCarnival.java
@@ -14,7 +14,7 @@ import server.maps.MapleReactor;
 import tools.MaplePacketCreator;

 /**
- * @author Drago/Dragohe4rt
+ * @author Drago (Dragohe4rt)
 */
 public class MonsterCarnival {

--- a/src/tools/MaplePacketCreator.java
+++ b/src/tools/MaplePacketCreator.java
@@ -2205,7 +2205,7 @@ public class MaplePacketCreator {
                mplew.write(game.getGameType().getValue());
                mplew.writeInt(game.getObjectId()); // gameid/shopid
                mplew.writeMapleAsciiString(game.getDescription()); // desc
-                mplew.writeBool(!game.getPassword().isEmpty());    // password here, thanks GabrielSin!
+                mplew.writeBool(!game.getPassword().isEmpty());    // password here, thanks GabrielSin
                mplew.write(game.getPieceType());
                mplew.write(ammount);
                mplew.write(2);         //player capacity
@@ -2219,7 +2219,7 @@ public class MaplePacketCreator {
                mplew.writeInt(hm.getObjectId());
                mplew.writeMapleAsciiString(hm.getDescription());
                mplew.write(hm.getItemId() % 100);
-                mplew.write(roomInfo);    // visitor capacity here, thanks GabrielSin!
+                mplew.write(roomInfo);    // visitor capacity here, thanks GabrielSin
        }
        
        public static byte[] updateHiredMerchantBox(MapleHiredMerchant hm) {
--- a/src/tools/packets/Wedding.java
+++ b/src/tools/packets/Wedding.java
@@ -17,7 +17,9 @@ import tools.data.output.MaplePacketLittleEndianWriter;
 /**
 * CField_Wedding, CField_WeddingPhoto, CWeddingMan, OnMarriageResult, and all Wedding/Marriage enum/structs.
 * 
- * @author Eric edited by Drago/Dragohe4rt on Wishlist
+ * @author Eric
+ * 
+ * Edited wishlists by -- Drago (Dragohe4rt)
 */
 public class Wedding extends MaplePacketCreator {
    private static final short MARRIAGE_REQUEST = 0x48;