From 10945927c19a19d39d90d5704140fda78db70d93 Mon Sep 17 00:00:00 2001 From: P0nk Date: Thu, 2 Mar 2023 18:11:41 +0100 Subject: [PATCH] Fix writeString not fully respecting charset The string would be cut short for charsets with characters more than 1 byte. --- src/main/java/net/packet/ByteBufOutPacket.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/net/packet/ByteBufOutPacket.java b/src/main/java/net/packet/ByteBufOutPacket.java index dbb8e75fbe..ce289603be 100644 --- a/src/main/java/net/packet/ByteBufOutPacket.java +++ b/src/main/java/net/packet/ByteBufOutPacket.java @@ -71,8 +71,9 @@ public class ByteBufOutPacket implements OutPacket { @Override public void writeString(String value) { - writeShort((short) value.length()); - writeBytes(value.getBytes(CharsetConstants.CHARSET)); + byte[] bytes = value.getBytes(CharsetConstants.CHARSET); + writeShort(bytes.length); + writeBytes(bytes); } @Override