From 948a9de667d2aed19e365811315f773b9cfb2135 Mon Sep 17 00:00:00 2001
From: P0nk <ponkcode@gmail.com>
Date: Tue, 21 May 2024 20:23:34 +0200
Subject: [PATCH] Remove Spirit of Rock die sound

---
 scripts/quest/2293.js     | 12 +++++++++---
 wz/Sound.wz/Field.img.xml |  3 ---
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/scripts/quest/2293.js b/scripts/quest/2293.js
index 4dbb21b61b..a82f18c3b7 100644
--- a/scripts/quest/2293.js
+++ b/scripts/quest/2293.js
@@ -50,8 +50,14 @@ function end(mode, type, selection) {
         status++;
     }
 
+    // TODO: there are 10 different riffs; quest2288/0 through quest2288/9.
+    // One of the riffs should play randomly upon the death of Spirit of Rock, but there is currently no system in place to achieve that in a reasonable way.
+    // Spirit of Rock (4300013) spawns an invisible mob on death (Spirit of Rock's Soul, 4300017) which was likely used in some clever way in GMS.
+    // The map (103040430) has two scripts which could be useful: onFirstUserEnter=Depart_Boss_F_Enter and onUserEnter=Depart_BossEnter
+    // Currently, the best hypothesis is that one of the map scripts registers some form of "mob spawn" action/script that runs once the invisible mob spawns.
+    // The script would randomly pick one of the 10 riffs and then register it with all chrs on the map (to later be used by this quest 2293) and play it.
     if (status == 0) {
-        qm.sendSimple("Here, I'll give you some samples. Please listen to them and choose one. Please listen carefully before making your choide.\r\n\
+        qm.sendSimple("Here, I'll give you some samples. Please listen to them and choose one. Please listen carefully before making your choice.\r\n\
             \t#b#L1# Listen to song No. 1#l \r\n\
             \t#L2# Listen to Song No. 2#l \r\n\
             \t#L3# Listen to Song No. 3#l \r\n\
@@ -67,7 +73,7 @@ function end(mode, type, selection) {
             qm.sendOk("Was it this?");
             status = -1;
         } else if (selection == 3) {
-            qm.playSound("quest2293/Die");
+            qm.playSound("quest2288/6");
             qm.sendOk("You heard that?");
             status = -1;
         } else if (selection == 4) {
@@ -88,4 +94,4 @@ function end(mode, type, selection) {
     } else if (status == 3) {
         qm.dispose();
     }
-}
\ No newline at end of file
+}
diff --git a/wz/Sound.wz/Field.img.xml b/wz/Sound.wz/Field.img.xml
index ed8a2cdc37..a9bea020ef 100644
--- a/wz/Sound.wz/Field.img.xml
+++ b/wz/Sound.wz/Field.img.xml
@@ -76,7 +76,4 @@
     <sound name="8"/>
     <sound name="9"/>
   </imgdir>
-  <imgdir name="quest2293">
-    <sound name="Die"/>
-  </imgdir>
 </imgdir>