PlayerNPC patch + Wedding ring effects + Bypassable PIN/PIC + SP cap

Fixed an issue with delayed item pickups.
Fixed ClearSlot command not removing rechargeables from inventory.
Fixed Resurrection and Hyper Body animation effect not working for other players.
Implemented bypassable PIN/PIC, applied on accounts after a successful authentication, remaining active while activity is detected for that account.
Fixed anti-multiclient system not properly registering players logged in via all-chars-view.
Fixed cases where players still could gain EXP from much higher-leveled mobs if they were on an event instance.
Optimized scroll result method performance.
Added a server flag for SP cap limit on the player's current job (missing amount are reobtained after changing jobs).
PlayerNPCs now have overridable scripts.
Fixed some mapobject issues with PlayerNPCs, potencially leading to disappearing from maps in certain circumstances.
Fixed SpawnAllPnpcs command not properly spawning all PlayersNPCs.
Added extra info on Abdula, now stating whether a book can be obtained from questline or not.
Fixed marriage ring effects.
Fixed some cases where marriage rings were being able to be sent out from the character owner.
Fixed Duey allowing send untradeable items.
New tool: MapleWorldmapChecker. It reads Map.wz XMLs, fetching mapids not properly referenced on the worldmap nodes.

docs/feature_list.md

@@ -6,6 +6,10 @@ Ronan - Head Developer
 
 Vcoc - Freelance Developer
 
+Thora - Contributor
+
+GabrielSin - Contributor
+
 ---------------------------
 DISCLAIMER:
 ---------------------------
@@ -58,6 +62,7 @@ Player Social Network:
 
 * Guild and Alliance system fully functional.
 * Implemented Marriage system from the ground-up (excluding character packet encoding parts that were already present, proper credits given throughout the source files).
+* Marriage ring effects functional.
 * Beginners can create and join a "beginner-only" party (characters up to level 10).
 * HP bar of party members now properly calculates the HP gain from equipments.
 * Enhanced synchronization on Player Shops and Hired Merchants. Transactions made are instantly informed to the owner.
@@ -174,7 +179,9 @@ Server potentials:
 * Both fixed and randomized versions of HP/MP growth rate available, regarding player job (enable one at ServerConstants). Placeholder for HP/MP washing feature.
 * Implemented methods to get the current Players' MaxHP/MaxMP method with equipment HP/MP gains already summed up.
 * Reallocated mapobjectids utilization throughout the source, preventing issues such as "NPC disappearing mysteriously after some server time" from happening.
-* Implemented old GMS statup mechanic for novices level 10 or below. Usage of the edited localhost is mandatory on this.
+* Implemented old GMS AP assigning for novices level 10 or below. Usage of the edited localhost is mandatory on this.
+* Implemented SP capping for players that passed the job upgrade level. After upgrading jobs, the missing SP amount is replenished.
+* Bypassable PIN/PIC system for players that were already authenticated and are currently loggedin and active.
 * Accounts can be created automatically when trying to login on an inexistent account -- credits to shavit.
 * Usage of Bcrypt (up-to-date) as the main password hashing algorithm, replacing old SHA's -- credits to shavit.
 
@@ -201,8 +208,9 @@ External tools:
 * MapleArrowFetcher - Updates min/max quantity dropped on all arrows drop data, calculations based on mob level and whether it's a boss or not.
 * MapleBossHpBarFetcher - Searches the quest WZ files and reports in all relevant data regarding mobs that has a boss HP bar whilst not having a proper "boss" label.
 * MapleCashDropFetcher - Searches the DB for any CASH drop data entry and lists them on a report file.
+* MapleCodeCouponGenerator - Reads the XML recipe at the input folder and loads into the DB new coupon codes bundled with all depicted items.
 * MapleCouponInstaller - Retrieves coupon info from the WZ and makes a SQL table with it. The server will use that table to gather info regarding rates and intervals.
-* MapleDojoUpdate - Patches the dojo WZ nodes with correct script names for onUserEnter and onFirstUserEnter fields.
+* MapleDojoUpdater - Patches the dojo WZ nodes with correct script names for onUserEnter and onFirstUserEnter fields.
 * MapleEquipmentOmnileveler - Updates the equipment WZ nodes with item level information, allowing thus access for item level and EXP info for common equipments.
 * MapleIdRetriever - Two behaviors: generates a SQL table with relation (id, name) of the handbook given as input. Given a file with names, outputs a file with ids.
 * MapleInvalidItemIdFetcher - Generates a file listing all inexistent itemid's currently laying on the DB.
@@ -218,6 +226,7 @@ External tools:
 * MapleReactorDropFetcher - Searches the DB for reactors with drop data and reports in reactorids that are not yet coded.
 * MapleSkillMakerFetcher - Updates the DB Maker-related tables with the current info present on the WZs.
 * MapleSkillMakerReagentIndexer - Generates a new maker table describing all stat-improvements from the Maker reagents (those empowering crystals and jewels).
+* MapleWorldmapChecker - Searches the map WZ files for map/field entries with missing tooltip informations (that would point which map the character currently is on the overworld maps).
 
 Project:
 

docs/issues.txt

@@ -14,11 +14,11 @@ Known issues:
 - Dragon Roar doesn't show the stun effect to players.
 - Some monster status such as freeze and weapon/magic reflect doesn't behave properly in certain scenarios. Freeze seems to not work on mobs with low OID or are starters from server boot time.
 - On low-end connections, things such as command summoning a player that is currently logging in (already visible to other players) may cause the player to freeze, consequently freezing the account as well since the server-side disconnection doesn't happen.
+- Reportedly, there are cases where mob positions fail to sync between player's client-view.
 ---------------------------
 
 ---------------------------
 Missing features list:
-- Miniroom tooltips (such as number of players in store/host awaiting game) not showing up properly.
 - Change name/World transfer.
 - Some pirate skills doesn't work for 3rd parties.
 - Cache frequently used SQL data.

docs/mychanges_ptbr.txt

@@ -1381,4 +1381,37 @@ Protegido concorrentemente módulos de chairs.
 
 09 Outubro 2018,
 Corrigido disease seduce não funcionando da forma esperada quando jogador está sentado.
-Movido Dropspider para fora do código-fonte do server, agora estando como uma ferramenta externa.
+Movido Dropspider para fora do código-fonte do server, agora estando como uma ferramenta externa.
+
+10 - 11 Outubro 2018,
+Corrigido comando ClearSlots não apagando recarregáveis do inventário.
+Adicionado busca por quests no comando Search.
+Corrigido notas musicais misturadas no mapa da harpa.
+Corrigido certas inconsistências com restanciação de jogadores, como pode ser visto ao aplicar Resurrection ou Hyper Body.
+Implementado funcionalidade "toggle PIN/PIC", após confirmado PIN/PIC jogador poderá evitar reutilizá-lo por um curto período de tempo.
+Corrigido sistema anti-multicliente não registrando devidamente jogadores que entram via all-chars.
+Corrigido casos onde jogadores muito abaixo do nível de mobs ainda poderiam ganhar EXP dos mesmos, quando se está dentro de um evento.
+
+13 - 16 Outubro 2018,
+Melhorada função que gerencia resultado no uso de scrolls.
+Implementado nova flag que permite bloquear ganho de SP ao atingir o cap para tal job, além de permitir recuperar pontos de SP assim que avançar de job.
+Adicionado possibilidade de overload de script para playerNPCs.
+Nova ferramenta: MapleWorldmapChecker. Verifica arquivo Map.wz em busca de possíveis mapids que não constam em hierarquias superiores de worldmaps.
+Adicionado informação extra ao NPC Abdula, agora definindo skill/mastery books como sendo parte de questline quando aplicável.
+Corrigido loots levando atraso arbitrariamente, devido a mudanças anteriores no código.
+
+17 Outubro 2018,
+Corrigido PlayerNPCs atuando inconsistentemente, por compartilhar objectid com personagens de jogadores.
+Corrigido comandos de colocar/retirar PlayerNPCs não atuando corretamente.
+Corrigido certos casos no uso do inventário de cash que leva itens a não serem retirados pelo jogador corretamente.
+Corrigido comando SpawnAllPnpcs não colocando de fato todos os personagens do servidor.
+
+18 Outubro 2018,
+Corrigido efeitos de rings de casamento não atuando corretamente.
+Implementado mecânica para reconhecimento de jogadores casados, agora jogadores podem ver efeitos dos respectivos itens.
+Removido possibilidade de colocar aneis de casamento no Cash Shop e Storage.
+Removido possibilidade de colocar itens "untradeable" no Duey.
+Removido possibilidade de preparar engagements enquanto segurando aneis de casamento.
+
+23 Outubro 2018,
+Adicionado script para quest de 4o job de Cygnus Knights.