Sweetgum/sweetgum-server
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use try-with-resources for PlayerNPC db operations

Browse Source
This commit is contained in:
P0nk
2021-04-04 23:12:39 +02:00
parent 5cb69910bd
commit 8ceba9fbee
1 changed files with 250 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

393
src/main/java/server/life/MaplePlayerNPC.java
View File

@@ -21,32 +21,17 @@
*/
package server.life;
import config.YamlConfig;
import server.life.positioner.MaplePlayerNPCPositioner;
import server.life.positioner.MaplePlayerNPCPodium;
import java.awt.Point;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.Connection;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;
import client.MapleCharacter;
import client.MapleClient;
import client.inventory.Item;
import client.inventory.MapleInventoryType;
import config.YamlConfig;
import constants.game.GameConstants;
import net.server.Server;
import net.server.channel.Channel;
import net.server.world.World;
import server.life.positioner.MaplePlayerNPCPodium;
import server.life.positioner.MaplePlayerNPCPositioner;
import server.maps.AbstractMapleMapObject;
import server.maps.MapleMap;
import server.maps.MapleMapObject;
@@ -55,6 +40,12 @@ import tools.DatabaseConnection;
import tools.MaplePacketCreator;
import tools.Pair;
import java.awt.*;
import java.sql.*;
import java.util.List;
import java.util.*;
import java.util.concurrent.atomic.AtomicInteger;
/**
*
* @author XoticStory
@@ -119,16 +110,16 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
setPosition(new Point(rs.getInt("x"), CY));
setObjectId(rs.getInt("id"));
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT equippos, equipid FROM playernpcs_equip WHERE npcid = ?");
ps.setInt(1, rs.getInt("id"));
ResultSet rs2 = ps.executeQuery();
while (rs2.next()) {
equips.put(rs2.getShort("equippos"), rs2.getInt("equipid"));
try (Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT equippos, equipid FROM playernpcs_equip WHERE npcid = ?")) {
ps.setInt(1, rs.getInt("id"));
try (ResultSet rs2 = ps.executeQuery()) {
while (rs2.next()) {
equips.put(rs2.getShort("equippos"), rs2.getInt("equipid"));
}
}
}
rs2.close();
ps.close();
con.close();
} catch (SQLException e) {
e.printStackTrace();
}
@@ -220,63 +211,52 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
}
private static void getRunningMetadata() {
try {
Connection con = DatabaseConnection.getConnection();
try (Connection con = DatabaseConnection.getConnection()) {
getRunningOverallRanks(con);
getRunningWorldRanks(con);
getRunningWorldJobRanks(con);
con.close();
} catch (SQLException e) {
e.printStackTrace();
}
}
private static void getRunningOverallRanks(Connection con) throws SQLException {
PreparedStatement ps = con.prepareStatement("SELECT max(overallrank) FROM playernpcs");
ResultSet rs = ps.executeQuery();
try (PreparedStatement ps = con.prepareStatement("SELECT max(overallrank) FROM playernpcs");
ResultSet rs = ps.executeQuery()) {
if(rs.next()) {
runningOverallRank.set(rs.getInt(1) + 1);
} else {
runningOverallRank.set(1);
if (rs.next()) {
runningOverallRank.set(rs.getInt(1) + 1);
} else {
runningOverallRank.set(1);
}
}
rs.close();
ps.close();
}
private static void getRunningWorldRanks(Connection con) throws SQLException {
int numWorlds = Server.getInstance().getWorldsSize();
for(int i = 0; i < numWorlds; i++) {
for (int i = 0; i < numWorlds; i++) {
runningWorldRank.add(new AtomicInteger(1));
}
PreparedStatement ps = con.prepareStatement("SELECT world, max(worldrank) FROM playernpcs GROUP BY world ORDER BY world");
ResultSet rs = ps.executeQuery();
try (PreparedStatement ps = con.prepareStatement("SELECT world, max(worldrank) FROM playernpcs GROUP BY world ORDER BY world");
ResultSet rs = ps.executeQuery()) {
while(rs.next()) {
int wid = rs.getInt(1);
if(wid < numWorlds) {
runningWorldRank.get(wid).set(rs.getInt(2) + 1);
while (rs.next()) {
int wid = rs.getInt(1);
if (wid < numWorlds) {
runningWorldRank.get(wid).set(rs.getInt(2) + 1);
}
}
}
rs.close();
ps.close();
}
private static void getRunningWorldJobRanks(Connection con) throws SQLException {
PreparedStatement ps = con.prepareStatement("SELECT world, job, max(worldjobrank) FROM playernpcs GROUP BY world, job ORDER BY world, job");
ResultSet rs = ps.executeQuery();
while(rs.next()) {
runningWorldJobRank.put(new Pair<>(rs.getInt(1), rs.getInt(2)), new AtomicInteger(rs.getInt(3) + 1));
try (PreparedStatement ps = con.prepareStatement("SELECT world, job, max(worldjobrank) FROM playernpcs GROUP BY world, job ORDER BY world, job");
ResultSet rs = ps.executeQuery()) {
while (rs.next()) {
runningWorldJobRank.put(new Pair<>(rs.getInt(1), rs.getInt(2)), new AtomicInteger(rs.getInt(3) + 1));
}
}
rs.close();
ps.close();
}
private static int getAndIncrementRunningWorldJobRanks(int world, int job) {
@@ -292,20 +272,16 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
public static boolean canSpawnPlayerNpc(String name, int mapid) {
boolean ret = true;
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT name FROM playernpcs WHERE name LIKE ? AND map = ?");
try (Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT name FROM playernpcs WHERE name LIKE ? AND map = ?")) {
ps.setString(1, name);
ps.setInt(2, mapid);
ResultSet rs = ps.executeQuery();
if(rs.next()) {
ret = false;
try (ResultSet rs = ps.executeQuery()) {
if (rs.next()) {
ret = false;
}
}
rs.close();
ps.close();
con.close();
} catch (SQLException e) {
e.printStackTrace();
}
@@ -320,10 +296,8 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
CY = newPos.y;
FH = map.getFootholds().findBelow(newPos).getId();
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("UPDATE playernpcs SET x = ?, cy = ?, fh = ?, rx0 = ?, rx1 = ? WHERE id = ?");
try (Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("UPDATE playernpcs SET x = ?, cy = ?, fh = ?, rx0 = ?, rx1 = ? WHERE id = ?")) {
ps.setInt(1, newPos.x);
ps.setInt(2, CY);
ps.setInt(3, FH);
@@ -331,9 +305,6 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
ps.setInt(5, RX1);
ps.setInt(6, getObjectId());
ps.executeUpdate();
ps.close();
con.close();
} catch (SQLException e) {
e.printStackTrace();
}
@@ -344,43 +315,41 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
int branchLen = (branch < 26) ? 100 : 400;
int branchSid = 9900000 + (branch * 100);
int nextBranchSid = branchSid + branchLen;
Set<Integer> usedScriptIds = new HashSet<>();
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT scriptid FROM playernpcs WHERE scriptid >= ? AND scriptid < ? ORDER BY scriptid");
ps.setInt(1, branchSid);
ps.setInt(2, nextBranchSid);
ResultSet rs = ps.executeQuery();
while(rs.next()) {
usedScriptIds.add(rs.getInt(1));
}
List<Integer> availables = new ArrayList<>(20);
int j = 0;
for(int i = branchSid; i < nextBranchSid; i++) {
if(!usedScriptIds.contains(i)) {
if (MaplePlayerNPCFactory.isExistentScriptid(i)) { // thanks Ark, Zein, geno, Ariel, JrCl0wn for noticing client crashes due to use of missing scriptids
availables.add(i);
j++;
try (Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT scriptid FROM playernpcs WHERE scriptid >= ? AND scriptid < ? ORDER BY scriptid")) {
ps.setInt(1, branchSid);
ps.setInt(2, nextBranchSid);
if(j == 20) {
break;
Set<Integer> usedScriptIds = new HashSet<>();
try (ResultSet rs = ps.executeQuery()) {
while (rs.next()) {
usedScriptIds.add(rs.getInt(1));
}
}
int j = 0;
for (int i = branchSid; i < nextBranchSid; i++) {
if (!usedScriptIds.contains(i)) {
if (MaplePlayerNPCFactory.isExistentScriptid(i)) { // thanks Ark, Zein, geno, Ariel, JrCl0wn for noticing client crashes due to use of missing scriptids
availables.add(i);
j++;
if (j == 20) {
break;
}
} else {
break; // after this point no more scriptids expected...
}
} else {
break; // after this point no more scriptids expected...
}
}
}
rs.close();
ps.close();
con.close();
for(int i = availables.size() - 1; i >= 0; i--) {
for (int i = availables.size() - 1; i >= 0; i--) {
list.add(availables.get(i));
}
} catch(SQLException sqle) {
} catch (SQLException sqle) {
sqle.printStackTrace();
}
}
@@ -407,7 +376,7 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
private static MaplePlayerNPC createPlayerNPCInternal(MapleMap map, Point pos, MapleCharacter chr) {
int mapId = map.getId();
if(!canSpawnPlayerNpc(chr.getName(), mapId)) {
if (!canSpawnPlayerNpc(chr.getName(), mapId)) {
return null;
}
@@ -418,89 +387,93 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
return null;
}
if(pos == null) {
if(GameConstants.isPodiumHallOfFameMap(map.getId())) {
if (pos == null) {
if (GameConstants.isPodiumHallOfFameMap(map.getId())) {
pos = MaplePlayerNPCPodium.getNextPlayerNpcPosition(map);
} else {
pos = MaplePlayerNPCPositioner.getNextPlayerNpcPosition(map);
}
if(pos == null) {
if (pos == null) {
return null;
}
}
if(YamlConfig.config.server.USE_DEBUG) System.out.println("GOT SID " + scriptId + " POS " + pos);
if (YamlConfig.config.server.USE_DEBUG) {
System.out.println("GOT SID " + scriptId + " POS " + pos);
}
int worldId = chr.getWorld();
int jobId = (chr.getJob().getId() / 100) * 100;
MaplePlayerNPC ret;
int npcId;
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT * FROM playernpcs WHERE scriptid = ?");
ps.setInt(1, scriptId);
ResultSet rs = ps.executeQuery();
if (!rs.next()) { // creates new playernpc if scriptid doesn't exist
rs.close();
ps.close();
try (Connection con = DatabaseConnection.getConnection()) {
boolean createNew = false;
try (PreparedStatement ps = con.prepareStatement("SELECT * FROM playernpcs WHERE scriptid = ?")) {
ps.setInt(1, scriptId);
ps = con.prepareStatement("INSERT INTO playernpcs (name, hair, face, skin, gender, x, cy, world, map, scriptid, dir, fh, rx0, rx1, worldrank, overallrank, worldjobrank, job) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", Statement.RETURN_GENERATED_KEYS);
ps.setString(1, chr.getName());
ps.setInt(2, chr.getHair());
ps.setInt(3, chr.getFace());
ps.setInt(4, chr.getSkinColor().getId());
ps.setInt(5, chr.getGender());
ps.setInt(6, pos.x);
ps.setInt(7, pos.y);
ps.setInt(8, worldId);
ps.setInt(9, mapId);
ps.setInt(10, scriptId);
ps.setInt(11, 1); // default direction
ps.setInt(12, map.getFootholds().findBelow(pos).getId());
ps.setInt(13, pos.x + 50);
ps.setInt(14, pos.x - 50);
ps.setInt(15, runningWorldRank.get(worldId).getAndIncrement());
ps.setInt(16, runningOverallRank.getAndIncrement());
ps.setInt(17, getAndIncrementRunningWorldJobRanks(worldId, jobId));
ps.setInt(18, jobId);
ps.executeUpdate();
rs = ps.getGeneratedKeys();
rs.next();
npcId = rs.getInt(1);
rs.close();
ps.close();
ps = con.prepareStatement("INSERT INTO playernpcs_equip (npcid, equipid, equippos) VALUES (?, ?, ?)");
ps.setInt(1, npcId);
for (Item equip : chr.getInventory(MapleInventoryType.EQUIPPED)) {
int position = Math.abs(equip.getPosition());
if ((position < 12 && position > 0) || (position > 100 && position < 112)) {
ps.setInt(2, equip.getItemId());
ps.setInt(3, equip.getPosition());
ps.addBatch();
try (ResultSet rs = ps.executeQuery()) {
if (!rs.next()) {
createNew = true;
}
}
ps.executeBatch();
ps.close();
}
ps = con.prepareStatement("SELECT * FROM playernpcs WHERE id = ?");
ps.setInt(1, npcId);
rs = ps.executeQuery();
if (createNew) { // creates new playernpc if scriptid doesn't exist
final int npcId;
try (PreparedStatement ps = con.prepareStatement("INSERT INTO playernpcs (name, hair, face, skin, gender, x, cy, world, map, scriptid, dir, fh, rx0, rx1, worldrank, overallrank, worldjobrank, job) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", Statement.RETURN_GENERATED_KEYS)) {
ps.setString(1, chr.getName());
ps.setInt(2, chr.getHair());
ps.setInt(3, chr.getFace());
ps.setInt(4, chr.getSkinColor().getId());
ps.setInt(5, chr.getGender());
ps.setInt(6, pos.x);
ps.setInt(7, pos.y);
ps.setInt(8, worldId);
ps.setInt(9, mapId);
ps.setInt(10, scriptId);
ps.setInt(11, 1); // default direction
ps.setInt(12, map.getFootholds().findBelow(pos).getId());
ps.setInt(13, pos.x + 50);
ps.setInt(14, pos.x - 50);
ps.setInt(15, runningWorldRank.get(worldId).getAndIncrement());
ps.setInt(16, runningOverallRank.getAndIncrement());
ps.setInt(17, getAndIncrementRunningWorldJobRanks(worldId, jobId));
ps.setInt(18, jobId);
ps.executeUpdate();
rs.next();
ret = new MaplePlayerNPC(rs);
try (ResultSet rs = ps.getGeneratedKeys()) {
rs.next();
npcId = rs.getInt(1);
}
}
try (PreparedStatement ps = con.prepareStatement("INSERT INTO playernpcs_equip (npcid, equipid, equippos) VALUES (?, ?, ?)")) {
ps.setInt(1, npcId);
for (Item equip : chr.getInventory(MapleInventoryType.EQUIPPED)) {
int position = Math.abs(equip.getPosition());
if ((position < 12 && position > 0) || (position > 100 && position < 112)) {
ps.setInt(2, equip.getItemId());
ps.setInt(3, equip.getPosition());
ps.addBatch();
}
}
ps.executeBatch();
}
try (PreparedStatement ps = con.prepareStatement("SELECT * FROM playernpcs WHERE id = ?")) {
ps.setInt(1, npcId);
try (ResultSet rs = ps.executeQuery()) {
rs.next();
ret = new MaplePlayerNPC(rs);
}
}
} else {
ret = null;
}
rs.close();
ps.close();
con.close();
return ret;
} catch (SQLException e) {
e.printStackTrace();
@@ -514,36 +487,34 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
List<Integer> mapids = new LinkedList<>();
mapids.add(chr.getWorld());
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT id, map FROM playernpcs WHERE name LIKE ?" + (map != null ? " AND map = ?" : ""));
try (Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT id, map FROM playernpcs WHERE name LIKE ?" + (map != null ? " AND map = ?" : ""))) {
ps.setString(1, chr.getName());
if(map != null) ps.setInt(2, map.getId());
ResultSet rs = ps.executeQuery();
while(rs.next()) {
updateMapids.add(rs.getInt("map"));
int npcId = rs.getInt("id");
PreparedStatement ps2 = con.prepareStatement("DELETE FROM playernpcs WHERE id = ?");
ps2.setInt(1, npcId);
ps2.executeUpdate();
ps2.close();
ps2 = con.prepareStatement("DELETE FROM playernpcs_equip WHERE npcid = ?");
ps2.setInt(1, npcId);
ps2.executeUpdate();
ps2.close();
if (map != null) {
ps.setInt(2, map.getId());
}
rs.close();
ps.close();
con.close();
try (ResultSet rs = ps.executeQuery()) {
while (rs.next()) {
updateMapids.add(rs.getInt("map"));
int npcId = rs.getInt("id");
try (PreparedStatement ps2 = con.prepareStatement("DELETE FROM playernpcs WHERE id = ?")) {
ps2.setInt(1, npcId);
ps2.executeUpdate();
}
try (PreparedStatement ps2 = con.prepareStatement("DELETE FROM playernpcs_equip WHERE npcid = ?")) {
ps2.setInt(1, npcId);
ps2.executeUpdate();
}
}
}
} catch (SQLException e) {
e.printStackTrace();
}
for(Integer i : updateMapids) {
for (Integer i : updateMapids) {
mapids.add(i);
}
@@ -630,21 +601,20 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
}
public static void removeAllPlayerNPC() {
try {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT DISTINCT world, map FROM playernpcs");
ResultSet rs = ps.executeQuery();
try (Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT DISTINCT world, map FROM playernpcs");
ResultSet rs = ps.executeQuery()) {
int wsize = Server.getInstance().getWorldsSize();
while(rs.next()) {
while (rs.next()) {
int world = rs.getInt("world"), map = rs.getInt("map");
if(world >= wsize) continue;
if (world >= wsize) {
continue;
}
for (Channel channel : Server.getInstance().getChannelsFromWorld(world)) {
MapleMap m = channel.getMapFactory().getMap(map);
for(MapleMapObject pnpcObj : m.getMapObjectsInRange(new Point(0, 0), Double.POSITIVE_INFINITY, Arrays.asList(MapleMapObjectType.PLAYER_NPC))) {
for (MapleMapObject pnpcObj : m.getMapObjectsInRange(new Point(0, 0), Double.POSITIVE_INFINITY, Arrays.asList(MapleMapObjectType.PLAYER_NPC))) {
MaplePlayerNPC pn = (MaplePlayerNPC) pnpcObj;
m.removeMapObject(pnpcObj);
m.broadcastMessage(MaplePacketCreator.removeNPCController(pn.getObjectId()));
@@ -653,26 +623,21 @@ public class MaplePlayerNPC extends AbstractMapleMapObject {
}
}
rs.close();
ps.close();
ps = con.prepareStatement("DELETE FROM playernpcs");
ps.executeUpdate();
ps.close();
ps = con.prepareStatement("DELETE FROM playernpcs_equip");
ps.executeUpdate();
ps.close();
ps = con.prepareStatement("DELETE FROM playernpcs_field");
ps.executeUpdate();
ps.close();
for(World w : Server.getInstance().getWorlds()) {
w.resetPlayerNpcMapData();
try (PreparedStatement ps2 = con.prepareStatement("DELETE FROM playernpcs")) {
ps2.executeUpdate();
}
con.close();
try (PreparedStatement ps2 = con.prepareStatement("DELETE FROM playernpcs_equip")) {
ps2.executeUpdate();
}
try (PreparedStatement ps2 = con.prepareStatement("DELETE FROM playernpcs_field")) {
ps2.executeUpdate();
}
for (World w : Server.getInstance().getWorlds()) {
w.resetPlayerNpcMapData();
}
} catch (SQLException e) {
e.printStackTrace();
}