Break up Orbis lens NPC script into multiple functions

scripts/npc/9200101.js

@@ -24,26 +24,8 @@
 */
 var status = 0;
 var beauty = 0;
-var regprice = 1000000;
-var vipprice = 1000000;
 var colors = Array();
 
-function pushIfItemExists(array, itemid) {
-    if ((itemid = cm.getCosmeticItem(itemid)) != -1 && !cm.isCosmeticEquipped(itemid)) {
-        array.push(itemid);
-    }
-}
-
-function pushIfItemsExists(array, itemidList) {
-    for (var i = 0; i < itemidList.length; i++) {
-        var itemid = itemidList[i];
-
-        if ((itemid = cm.getCosmeticItem(itemid)) != -1 && !cm.isCosmeticEquipped(itemid)) {
-            array.push(itemid);
-        }
-    }
-}
-
 function start() {
     status = -1;
     action(1, 0, 0);
@@ -63,44 +45,73 @@ function action(mode, type, selection) {
         } else if (status == 1) {
             if (selection == 1) {
                 beauty = 1;
+                selectedRegularCoupon()
+            } else if (selection == 2) {
+                beauty = 2;
+                selectedVipCoupon()
+            } else if (selection == 3) {
+                beauty = 3;
+                selectedOneTimeCoupon()
+            }
+        } else if (status == 2) {
+            cm.dispose();
+            if (beauty == 1) {
+                acceptedRegularCoupon()
+            } else if (beauty == 2) {
+                selectedVipStyle(selection)
+            } else if (beauty == 3) {
+                selectedOneTimeStyle(selection)
+            }
+        }
+    }
+}
+
+function selectedRegularCoupon() {
     if (cm.getPlayer().getGender() == 0) {
-                    var current = cm.getPlayer().getFace()
+        var current = cm.getPlayer().getFace() % 100 + 20000;
-                        % 100 + 20000;
     }
     if (cm.getPlayer().getGender() == 1) {
-                    var current = cm.getPlayer().getFace()
+        var current = cm.getPlayer().getFace() % 100 + 21000;
-                        % 100 + 21000;
     }
     colors = Array();
     pushIfItemsExists(colors, [current + 100, current + 300, current + 400, current + 700]);
     cm.sendYesNo("If you use the regular coupon, you'll be awarded a random pair of cosmetic lenses. Are you going to use a #b#t5152011##k and really make the change to your eyes?");
-            } else if (selection == 2) {
+}
-                beauty = 2;
+
+function selectedVipCoupon() {
     if (cm.getPlayer().getGender() == 0) {
-                    var current = cm.getPlayer().getFace()
+        var current = cm.getPlayer().getFace() % 100 + 20000;
-                        % 100 + 20000;
     }
     if (cm.getPlayer().getGender() == 1) {
-                    var current = cm.getPlayer().getFace()
+        var current = cm.getPlayer().getFace() % 100 + 21000;
-                        % 100 + 21000;
     }
     colors = Array();
     pushIfItemsExists(colors, [current + 100, current + 300, current + 400, current + 700]);
     cm.sendStyle("With our new computer program, you can see yourself after the treatment in advance. What kind of lens would you like to wear? Please choose the style of your liking.", colors);
-            } else if (selection == 3) {
+}
-                beauty = 3;
+
+function pushIfItemsExists(array, itemidList) {
+    for (var i = 0; i < itemidList.length; i++) {
+        var itemid = itemidList[i];
+
+        if ((itemid = cm.getCosmeticItem(itemid)) != -1 && !cm.isCosmeticEquipped(itemid)) {
+            array.push(itemid);
+        }
+    }
+}
+
+function selectedOneTimeCoupon() {
     if (cm.getPlayer().getGender() == 0) {
-                    var current = cm.getPlayer().getFace()
+        var current = cm.getPlayer().getFace() % 100 + 20000;
-                        % 100 + 20000;
     }
     if (cm.getPlayer().getGender() == 1) {
-                    var current = cm.getPlayer().getFace()
+        var current = cm.getPlayer().getFace() % 100 + 21000;
-                        % 100 + 21000;
     }
 
     colors = Array();
     for (var i = 0; i < 8; i++) {
-                    if (cm.haveItem(5152100 + i)) {
+        const oneTimeCouponId = 5152100 + i
+        if (cm.haveItem(oneTimeCouponId)) {
             pushIfItemExists(colors, current + 100 * i);
         }
     }
@@ -113,25 +124,34 @@ function action(mode, type, selection) {
 
     cm.sendStyle("What kind of lens would you like to wear? Please choose the style of your liking.", colors);
 }
-        } else if (status == 2) {
+
-            cm.dispose();
+function pushIfItemExists(array, itemid) {
-            if (beauty == 1) {
+    if ((itemid = cm.getCosmeticItem(itemid)) != -1 && !cm.isCosmeticEquipped(itemid)) {
+        array.push(itemid);
+    }
+}
+
+function acceptedRegularCoupon() {
     if (cm.haveItem(5152011)) {
         cm.gainItem(5152011, -1);
         cm.setFace(colors[Math.floor(Math.random() * colors.length)]);
         cm.sendOk("Enjoy your new and improved cosmetic lenses!");
     } else {
-                    cm.sendOk("I'm sorry, but I don't think you have our cosmetic lens coupon with you right now. Without the coupon, I'm afraid I can't do it for you..");
+        sendLackingCoupon()
     }
-            } else if (beauty == 2) {
+}
+
+function selectedVipStyle(selection) {
     if (cm.haveItem(5152014)) {
         cm.gainItem(5152014, -1);
         cm.setFace(colors[selection]);
         cm.sendOk("Enjoy your new and improved cosmetic lenses!");
     } else {
-                    cm.sendOk("I'm sorry, but I don't think you have our cosmetic lens coupon with you right now. Without the coupon, I'm afraid I can't do it for you..");
+        sendLackingCoupon()
     }
-            } else if (beauty == 3) {
+}
+
+function selectedOneTimeStyle(selection) {
     var color = (colors[selection] / 100) % 100 | 0;
 
     if (cm.haveItem(5152100 + color)) {
@@ -139,21 +159,10 @@ function action(mode, type, selection) {
         cm.setFace(colors[selection]);
         cm.sendOk("Enjoy your new and improved cosmetic lenses!");
     } else {
+        sendLackingCoupon()
+    }
+}
+
+function sendLackingCoupon() {
     cm.sendOk("I'm sorry, but I don't think you have our cosmetic lens coupon with you right now. Without the coupon, I'm afraid I can't do it for you..");
 }
-            } else if (beauty == 0) {
-                if (selection == 0 && cm.getMeso() >= regprice) {
-                    cm.gainMeso(-regprice);
-                    cm.gainItem(5152011, 1);
-                    cm.sendOk("Enjoy!");
-                } else if (selection == 1 && cm.getMeso() >= vipprice) {
-                    cm.gainMeso(-vipprice);
-                    cm.gainItem(5152014, 1);
-                    cm.sendOk("Enjoy!");
-                } else {
-                    cm.sendOk("You don't have enough mesos to buy a coupon!");
-                }
-            }
-        }
-    }
-}