Addressed nitpicks and removed unused item ID constants

This commit is contained in:
Silwhoon
2024-02-05 17:00:18 +00:00
parent a7931c3e4d
commit 6f68f4edfd
4 changed files with 12 additions and 52 deletions

View File

@@ -88,7 +88,7 @@ public abstract class CharacterFactory {
equipped.addItemFromDB(eq_weapon.copy());
}
if (!MakeCharInfoHandler.isNewCharacterValid(newCharacter)) {
if (!MakeCharInfoValidator.isNewCharacterValid(newCharacter)) {
log.warn("Owner from account {} tried to packet edit in character creation", c.getAccountName());
return -2;
}

View File

@@ -8,8 +8,8 @@ import org.slf4j.LoggerFactory;
import provider.Data;
import provider.DataTool;
import java.util.ArrayList;
import java.util.List;
import java.util.HashSet;
import java.util.Set;
public class MakeCharInfo {
private static final Logger log = LoggerFactory.getLogger(MakeCharInfo.class);
@@ -22,14 +22,14 @@ public class MakeCharInfo {
private static final String SHOE_ID = "6";
private static final String WEAPON_ID = "7";
private final List<Integer> charFaces = new ArrayList<>();
private final List<Integer> charHairs = new ArrayList<>();
private final List<Integer> charHairColors = new ArrayList<>();
private final List<Integer> charSkins = new ArrayList<>();
private final List<Integer> charTops = new ArrayList<>();
private final List<Integer> charBottoms = new ArrayList<>();
private final List<Integer> charShoes = new ArrayList<>();
private final List<Integer> charWeapons = new ArrayList<>();
private final Set<Integer> charFaces = new HashSet<>();
private final Set<Integer> charHairs = new HashSet<>();
private final Set<Integer> charHairColors = new HashSet<>();
private final Set<Integer> charSkins = new HashSet<>();
private final Set<Integer> charTops = new HashSet<>();
private final Set<Integer> charBottoms = new HashSet<>();
private final Set<Integer> charShoes = new HashSet<>();
private final Set<Integer> charWeapons = new HashSet<>();
public MakeCharInfo(Data charInfoData) {
for (Data data : charInfoData.getChildren()) {

View File

@@ -5,7 +5,7 @@ import provider.Data;
import provider.DataProviderFactory;
import provider.wz.WZFiles;
public class MakeCharInfoHandler {
public class MakeCharInfoValidator {
private static final MakeCharInfo charFemale;
private static final MakeCharInfo charMale;
private static final MakeCharInfo orientCharFemale;