Sweetgum/sweetgum-server
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use try-with-resources for alliance db operations

Browse Source
This commit is contained in:
P0nk
2021-04-04 15:19:32 +02:00
parent b350fedc66
commit 5899cce9d8
1 changed files with 168 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

176
src/main/java/net/server/guild/MapleAlliance.java
View File

@@ -21,13 +21,6 @@
*/ */
package net.server.guild; package net.server.guild;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.sql.ResultSet;
import java.util.LinkedList;
import java.util.List;
import client.MapleCharacter; import client.MapleCharacter;
import client.MapleClient; import client.MapleClient;
import net.server.Server; import net.server.Server;
@@ -39,8 +32,14 @@ import net.server.world.MaplePartyCharacter;
import tools.DatabaseConnection; import tools.DatabaseConnection;
import tools.MaplePacketCreator; import tools.MaplePacketCreator;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.LinkedList;
import java.util.List;
/** /**
*
* @author XoticStory * @author XoticStory
* @author Ronan * @author Ronan
*/ */
@@ -51,7 +50,7 @@ public class MapleAlliance {
private int capacity; private int capacity;
private String name; private String name;
private String notice = ""; private String notice = "";
private String rankTitles[] = new String[5]; private String[] rankTitles = new String[5];
public MapleAlliance(String name, int id) { public MapleAlliance(String name, int id) {
this.name = name; this.name = name;
@@ -66,20 +65,17 @@ public class MapleAlliance {
if (name.contains(" ") || name.length() > 12) { if (name.contains(" ") || name.length() > 12) {
return false; return false;
} }
try {
ResultSet rs; try (Connection con = DatabaseConnection.getConnection();
Connection con = DatabaseConnection.getConnection(); PreparedStatement ps = con.prepareStatement("SELECT name FROM alliance WHERE name = ?")) {
try (PreparedStatement ps = con.prepareStatement("SELECT name FROM alliance WHERE name = ?")) {
ps.setString(1, name); ps.setString(1, name);
rs = ps.executeQuery();
try (ResultSet rs = ps.executeQuery()) {
if (rs.next()) { if (rs.next()) {
ps.close();
rs.close();
return false; return false;
} }
} }
rs.close();
con.close();
return true; return true;
} catch (SQLException e) { } catch (SQLException e) {
e.printStackTrace(); e.printStackTrace();
@@ -115,15 +111,20 @@ public class MapleAlliance {
public static MapleAlliance createAlliance(MapleParty party, String name) { public static MapleAlliance createAlliance(MapleParty party, String name) {
List<MapleCharacter> guildMasters = getPartyGuildMasters(party); List<MapleCharacter> guildMasters = getPartyGuildMasters(party);
if(guildMasters.size() != 2) return null; if (guildMasters.size() != 2) {
return null;
}
List<Integer> guilds = new LinkedList<>(); List<Integer> guilds = new LinkedList<>();
for(MapleCharacter mc: guildMasters) guilds.add(mc.getGuildId()); for (MapleCharacter mc : guildMasters) {
guilds.add(mc.getGuildId());
}
MapleAlliance alliance = MapleAlliance.createAllianceOnDb(guilds, name); MapleAlliance alliance = MapleAlliance.createAllianceOnDb(guilds, name);
if (alliance != null) { if (alliance != null) {
alliance.setCapacity(guilds.size()); alliance.setCapacity(guilds.size());
for(Integer g: guilds) for (Integer g : guilds) {
alliance.addGuild(g); alliance.addGuild(g);
}
int id = alliance.getId(); int id = alliance.getId();
try { try {
@@ -155,35 +156,29 @@ public class MapleAlliance {
// will create an alliance, where the first guild listed is the leader and the alliance name MUST BE already checked for unicity. // will create an alliance, where the first guild listed is the leader and the alliance name MUST BE already checked for unicity.
int id = -1; int id = -1;
try { try (Connection con = DatabaseConnection.getConnection()) {
Connection con = DatabaseConnection.getConnection(); try (PreparedStatement ps = con.prepareStatement("INSERT INTO `alliance` (`name`) VALUES (?)", PreparedStatement.RETURN_GENERATED_KEYS)) {
PreparedStatement ps = con.prepareStatement("INSERT INTO `alliance` (`name`) VALUES (?)", PreparedStatement.RETURN_GENERATED_KEYS);
ps.setString(1, name); ps.setString(1, name);
ps.executeUpdate(); ps.executeUpdate();
try (ResultSet rs = ps.getGeneratedKeys()) { try (ResultSet rs = ps.getGeneratedKeys()) {
rs.next(); rs.next();
id = rs.getInt(1); id = rs.getInt(1);
} }
}
for(int i = 0; i < guilds.size(); i++) { for (int guild : guilds) {
int guild = guilds.get(i); try (PreparedStatement ps = con.prepareStatement("INSERT INTO `allianceguilds` (`allianceid`, `guildid`) VALUES (?, ?)")) {
ps = con.prepareStatement("INSERT INTO `allianceguilds` (`allianceid`, `guildid`) VALUES (?, ?)");
ps.setInt(1, id); ps.setInt(1, id);
ps.setInt(2, guild); ps.setInt(2, guild);
ps.executeUpdate(); ps.executeUpdate();
ps.close();
} }
}
ps.close();
con.close();
} catch (SQLException e) { } catch (SQLException e) {
e.printStackTrace(); e.printStackTrace();
return null; return null;
} }
return (new MapleAlliance(name, id)); return new MapleAlliance(name, id);
} }
public static MapleAlliance loadAlliance(int id) { public static MapleAlliance loadAlliance(int id) {
@@ -191,54 +186,50 @@ public class MapleAlliance {
return null; return null;
} }
MapleAlliance alliance = new MapleAlliance(null, -1); MapleAlliance alliance = new MapleAlliance(null, -1);
try { try (Connection con = DatabaseConnection.getConnection()) {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("SELECT * FROM alliance WHERE id = ?"); try (PreparedStatement ps = con.prepareStatement("SELECT * FROM alliance WHERE id = ?")) {
ps.setInt(1, id); ps.setInt(1, id);
ResultSet rs = ps.executeQuery();
try (ResultSet rs = ps.executeQuery()) {
if (!rs.next()) { if (!rs.next()) {
rs.close();
ps.close();
con.close();
return null; return null;
} }
alliance.allianceId = id; alliance.allianceId = id;
alliance.capacity = rs.getInt("capacity"); alliance.capacity = rs.getInt("capacity");
alliance.name = rs.getString("name"); alliance.name = rs.getString("name");
alliance.notice = rs.getString("notice"); alliance.notice = rs.getString("notice");
String ranks[] = new String[5]; String[] ranks = new String[5];
ranks[0] = rs.getString("rank1"); ranks[0] = rs.getString("rank1");
ranks[1] = rs.getString("rank2"); ranks[1] = rs.getString("rank2");
ranks[2] = rs.getString("rank3"); ranks[2] = rs.getString("rank3");
ranks[3] = rs.getString("rank4"); ranks[3] = rs.getString("rank4");
ranks[4] = rs.getString("rank5"); ranks[4] = rs.getString("rank5");
alliance.rankTitles = ranks; alliance.rankTitles = ranks;
}
}
ps.close(); try (PreparedStatement ps = con.prepareStatement("SELECT guildid FROM allianceguilds WHERE allianceid = ?")) {
rs.close();
ps = con.prepareStatement("SELECT guildid FROM allianceguilds WHERE allianceid = ?");
ps.setInt(1, id); ps.setInt(1, id);
rs = ps.executeQuery(); try (ResultSet rs = ps.executeQuery()) {
while (rs.next()) { while (rs.next()) {
alliance.addGuild(rs.getInt("guildid")); alliance.addGuild(rs.getInt("guildid"));
} }
}
ps.close(); }
rs.close();
con.close();
} catch (SQLException e) { } catch (SQLException e) {
e.printStackTrace(); e.printStackTrace();
} }
return alliance; return alliance;
} }
public void saveToDB() { public void saveToDB() {
try { try (Connection con = DatabaseConnection.getConnection()) {
Connection con = DatabaseConnection.getConnection();
PreparedStatement ps = con.prepareStatement("UPDATE `alliance` SET capacity = ?, notice = ?, rank1 = ?, rank2 = ?, rank3 = ?, rank4 = ?, rank5 = ? WHERE id = ?"); try (PreparedStatement ps = con.prepareStatement("UPDATE `alliance` SET capacity = ?, notice = ?, rank1 = ?, rank2 = ?, rank3 = ?, rank4 = ?, rank5 = ? WHERE id = ?")) {
ps.setInt(1, this.capacity); ps.setInt(1, this.capacity);
ps.setString(2, this.notice); ps.setString(2, this.notice);
@@ -250,89 +241,52 @@ public class MapleAlliance {
ps.setInt(8, this.allianceId); ps.setInt(8, this.allianceId);
ps.executeUpdate(); ps.executeUpdate();
ps.close(); }
ps = con.prepareStatement("DELETE FROM `allianceguilds` WHERE allianceid = ?"); try (PreparedStatement ps = con.prepareStatement("DELETE FROM `allianceguilds` WHERE allianceid = ?")) {
ps.setInt(1, this.allianceId); ps.setInt(1, this.allianceId);
ps.executeUpdate(); ps.executeUpdate();
ps.close(); }
for(int i = 0; i < guilds.size(); i++) { for (int guild : guilds) {
int guild = guilds.get(i); try (PreparedStatement ps = con.prepareStatement("INSERT INTO `allianceguilds` (`allianceid`, `guildid`) VALUES (?, ?)")) {
ps = con.prepareStatement("INSERT INTO `allianceguilds` (`allianceid`, `guildid`) VALUES (?, ?)");
ps.setInt(1, this.allianceId); ps.setInt(1, this.allianceId);
ps.setInt(2, guild); ps.setInt(2, guild);
ps.executeUpdate(); ps.executeUpdate();
ps.close();
} }
}
con.close();
} catch (SQLException e) { } catch (SQLException e) {
e.printStackTrace(); e.printStackTrace();
} }
} }
public static void disbandAlliance(int allianceId) { public static void disbandAlliance(int allianceId) {
PreparedStatement ps = null; try (Connection con = DatabaseConnection.getConnection()) {
Connection con = null;
try {
con = DatabaseConnection.getConnection();
ps = con.prepareStatement("DELETE FROM `alliance` WHERE id = ?"); try (PreparedStatement ps = con.prepareStatement("DELETE FROM `alliance` WHERE id = ?")) {
ps.setInt(1, allianceId); ps.setInt(1, allianceId);
ps.executeUpdate(); ps.executeUpdate();
ps.close(); }
ps = con.prepareStatement("DELETE FROM `allianceguilds` WHERE allianceid = ?"); try (PreparedStatement ps = con.prepareStatement("DELETE FROM `allianceguilds` WHERE allianceid = ?")) {
ps.setInt(1, allianceId); ps.setInt(1, allianceId);
ps.executeUpdate(); ps.executeUpdate();
ps.close(); }
con.close();
Server.getInstance().allianceMessage(allianceId, MaplePacketCreator.disbandAlliance(allianceId), -1, -1); Server.getInstance().allianceMessage(allianceId, MaplePacketCreator.disbandAlliance(allianceId), -1, -1);
Server.getInstance().disbandAlliance(allianceId); Server.getInstance().disbandAlliance(allianceId);
} catch (SQLException sqle) { } catch (SQLException sqle) {
sqle.printStackTrace(); sqle.printStackTrace();
} finally {
try {
if (ps != null && !ps.isClosed()) {
ps.close();
}
if (con != null && !con.isClosed()) {
con.close();
}
} catch (SQLException ex) {
ex.printStackTrace();
}
} }
} }
private static void removeGuildFromAllianceOnDb(int guildId) { private static void removeGuildFromAllianceOnDb(int guildId) {
PreparedStatement ps = null; try (Connection con = DatabaseConnection.getConnection();
Connection con = null; PreparedStatement ps = con.prepareStatement("DELETE FROM `allianceguilds` WHERE guildid = ?")) {
try {
con = DatabaseConnection.getConnection();
ps = con.prepareStatement("DELETE FROM `allianceguilds` WHERE guildid = ?");
ps.setInt(1, guildId); ps.setInt(1, guildId);
ps.executeUpdate(); ps.executeUpdate();
ps.close();
con.close();
} catch (SQLException sqle) { } catch (SQLException sqle) {
sqle.printStackTrace(); sqle.printStackTrace();
} finally {
try {
if (ps != null && !ps.isClosed()) {
ps.close();
}
if (con != null && !con.isClosed()) {
con.close();
}
} catch (SQLException ex) {
ex.printStackTrace();
}
} }
} }
@@ -366,7 +320,9 @@ public class MapleAlliance {
public boolean removeGuild(int gid) { public boolean removeGuild(int gid) {
synchronized (guilds) { synchronized (guilds) {
int index = getGuildIndex(gid); int index = getGuildIndex(gid);
if(index == -1) return false; if (index == -1) {
return false;
}
guilds.remove(index); guilds.remove(index);
return true; return true;
@@ -375,7 +331,9 @@ public class MapleAlliance {
public boolean addGuild(int gid) { public boolean addGuild(int gid) {
synchronized (guilds) { synchronized (guilds) {
if(guilds.size() == capacity || getGuildIndex(gid) > -1) return false; if (guilds.size() == capacity || getGuildIndex(gid) > -1) {
return false;
}
guilds.add(gid); guilds.add(gid);
return true; return true;
@@ -451,7 +409,9 @@ public class MapleAlliance {
MapleGuild guild = Server.getInstance().getGuild(gId); MapleGuild guild = Server.getInstance().getGuild(gId);
MapleGuildCharacter mgc = guild.getMGC(guild.getLeaderId()); MapleGuildCharacter mgc = guild.getMGC(guild.getLeaderId());
if(mgc.getAllianceRank() == 1) return mgc; if (mgc.getAllianceRank() == 1) {
return mgc;
}
} }
return null; return null;