From 54cdba01aef107c96ea645a0cae992e4ac2dbd7a Mon Sep 17 00:00:00 2001 From: salem909 Date: Tue, 15 Oct 2019 11:13:22 -0700 Subject: [PATCH] Update AbstractMovementPacketHandler (#532) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit updatePosition should throw exception too in default case 👍 --- .../server/channel/handlers/AbstractMovementPacketHandler.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/net/server/channel/handlers/AbstractMovementPacketHandler.java b/src/net/server/channel/handlers/AbstractMovementPacketHandler.java index 621946e15d..2c56a360da 100644 --- a/src/net/server/channel/handlers/AbstractMovementPacketHandler.java +++ b/src/net/server/channel/handlers/AbstractMovementPacketHandler.java @@ -41,6 +41,7 @@ public abstract class AbstractMovementPacketHandler extends AbstractMaplePacketH protected List parseMovement(LittleEndianAccessor lea) throws EmptyMovementException { List res = new ArrayList<>(); byte numCommands = lea.readByte(); + if (numCommands < 1) throw new EmptyMovementException(lea); for (byte i = 0; i < numCommands; i++) { byte command = lea.readByte(); switch (command) { @@ -236,7 +237,7 @@ public abstract class AbstractMovementPacketHandler extends AbstractMaplePacketH } default: System.out.println("Unhandled Case:" + command); - return; + throw new EmptyMovementException(lea); } } }