Sweetgum/sweetgum-server
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use try-with-resources for nx coupon db operations

Browse Source
This commit is contained in:
P0nk
2021-04-05 00:09:51 +02:00
parent 0334391e33
commit 429f82e4fe
1 changed files with 63 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

123
src/main/java/net/server/channel/handlers/CouponCodeHandler.java
View File

@@ -23,20 +23,10 @@
*/ */
package net.server.channel.handlers; package net.server.channel.handlers;
import client.MapleClient;
import client.MapleCharacter; import client.MapleCharacter;
import client.MapleClient;
import client.inventory.Item; import client.inventory.Item;
import client.inventory.manipulator.MapleInventoryManipulator; import client.inventory.manipulator.MapleInventoryManipulator;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Arrays;
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import net.AbstractMaplePacketHandler; import net.AbstractMaplePacketHandler;
import net.server.Server; import net.server.Server;
import server.CashShop; import server.CashShop;
@@ -47,6 +37,13 @@ import tools.MaplePacketCreator;
import tools.Pair; import tools.Pair;
import tools.data.input.SeekableLittleEndianAccessor; import tools.data.input.SeekableLittleEndianAccessor;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.*;
import java.util.Map.Entry;
/** /**
* *
* @author Penguins (Acrylic) * @author Penguins (Acrylic)
@@ -58,34 +55,33 @@ public final class CouponCodeHandler extends AbstractMaplePacketHandler {
Map<Integer, Integer> couponItems = new HashMap<>(); Map<Integer, Integer> couponItems = new HashMap<>();
Map<Integer, Integer> couponPoints = new HashMap<>(5); Map<Integer, Integer> couponPoints = new HashMap<>(5);
PreparedStatement ps = con.prepareStatement("SELECT * FROM nxcode_items WHERE codeid = ?"); try (PreparedStatement ps = con.prepareStatement("SELECT * FROM nxcode_items WHERE codeid = ?")) {
ps.setInt(1, codeid); ps.setInt(1, codeid);
ResultSet rs = ps.executeQuery(); try (ResultSet rs = ps.executeQuery()) {
while (rs.next()) { while (rs.next()) {
int type = rs.getInt("type"), quantity = rs.getInt("quantity"); int type = rs.getInt("type"), quantity = rs.getInt("quantity");
if (type < 5) { if (type < 5) {
Integer i = couponPoints.get(type); Integer i = couponPoints.get(type);
if (i != null) { if (i != null) {
couponPoints.put(type, i + quantity); couponPoints.put(type, i + quantity);
} else { } else {
couponPoints.put(type, quantity); couponPoints.put(type, quantity);
} }
} else { } else {
int item = rs.getInt("item"); int item = rs.getInt("item");
Integer i = couponItems.get(item); Integer i = couponItems.get(item);
if (i != null) { if (i != null) {
couponItems.put(item, i + quantity); couponItems.put(item, i + quantity);
} else { } else {
couponItems.put(item, quantity); couponItems.put(item, quantity);
}
}
} }
} }
} }
rs.close();
ps.close();
List<Pair<Integer, Pair<Integer, Integer>>> ret = new LinkedList<>(); List<Pair<Integer, Pair<Integer, Integer>>> ret = new LinkedList<>();
if (!couponItems.isEmpty()) { if (!couponItems.isEmpty()) {
for (Entry<Integer, Integer> e : couponItems.entrySet()) { for (Entry<Integer, Integer> e : couponItems.entrySet()) {
@@ -123,39 +119,38 @@ public final class CouponCodeHandler extends AbstractMaplePacketHandler {
return new Pair<>(-5, null); return new Pair<>(-5, null);
} }
Connection con = DatabaseConnection.getConnection(); try (Connection con = DatabaseConnection.getConnection()) {
PreparedStatement ps = con.prepareStatement("SELECT * FROM nxcode WHERE code = ?"); try (PreparedStatement ps = con.prepareStatement("SELECT * FROM nxcode WHERE code = ?")) {
ps.setString(1, code); ps.setString(1, code);
ResultSet rs = ps.executeQuery(); try (ResultSet rs = ps.executeQuery()) {
if (!rs.next()) { if (!rs.next()) {
return new Pair<>(-1, null); return new Pair<>(-1, null);
}
if (rs.getString("retriever") != null) {
return new Pair<>(-2, null);
}
if (rs.getLong("expiration") < Server.getInstance().getCurrentTime()) {
return new Pair<>(-3, null);
}
final int codeid = rs.getInt("id");
ret = getNXCodeItems(chr, con, codeid);
if (ret == null) {
return new Pair<>(-4, null);
}
}
}
try (PreparedStatement ps = con.prepareStatement("UPDATE nxcode SET retriever = ? WHERE code = ?")) {
ps.setString(1, chr.getName());
ps.setString(2, code);
ps.executeUpdate();
}
} }
if (rs.getString("retriever") != null) {
return new Pair<>(-2, null);
}
if (rs.getLong("expiration") < Server.getInstance().getCurrentTime()) {
return new Pair<>(-3, null);
}
int codeid = rs.getInt("id");
rs.close();
ps.close();
ret = getNXCodeItems(chr, con, codeid);
if (ret == null) {
return new Pair<>(-4, null);
}
ps = con.prepareStatement("UPDATE nxcode SET retriever = ? WHERE code = ?");
ps.setString(1, chr.getName());
ps.setString(2, code);
ps.executeUpdate();
ps.close();
con.close();
} catch (SQLException ex) { } catch (SQLException ex) {
ex.printStackTrace(); ex.printStackTrace();
} }