Sweetgum/sweetgum-server
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix ranking update query using a keyword for field name

Browse Source 
"Rank" is a reserved keyword in MySQL 8.
This caused an SQLSyntaxErrorException during the task run.
This commit is contained in:
P0nk
2021-04-06 21:09:07 +02:00
parent 02256e04ed
commit 2f34b3ed8b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/net/server/task/RankingLoginTask.java
View File

@@ -48,7 +48,7 @@ public class RankingLoginTask implements Runnable {
} }
private void updateRanking(int job, int world) throws SQLException { private void updateRanking(int job, int world) throws SQLException {
String sqlCharSelect = "SELECT c.id, " + (job != -1 ? "c.jobRank, c.jobRankMove" : "c.rank, c.rankMove") + ", a.lastlogin AS lastlogin, a.loggedin FROM characters AS c LEFT JOIN accounts AS a ON c.accountid = a.id WHERE c.gm < 2 AND c.world = ? "; String sqlCharSelect = "SELECT c.id, " + (job != -1 ? "c.jobRank, c.jobRankMove" : "c.`rank`, c.rankMove") + ", a.lastlogin AS lastlogin, a.loggedin FROM characters AS c LEFT JOIN accounts AS a ON c.accountid = a.id WHERE c.gm < 2 AND c.world = ? ";
if (job != -1) { if (job != -1) {
sqlCharSelect += "AND c.job DIV 100 = ? "; sqlCharSelect += "AND c.job DIV 100 = ? ";
} }
@@ -62,7 +62,7 @@ public class RankingLoginTask implements Runnable {
} }
try (ResultSet rs = charSelect.executeQuery(); try (ResultSet rs = charSelect.executeQuery();
PreparedStatement ps = con.prepareStatement("UPDATE characters SET " + (job != -1 ? "jobRank = ?, jobRankMove = ? " : "rank = ?, rankMove = ? ") + "WHERE id = ?")) { PreparedStatement ps = con.prepareStatement("UPDATE characters SET " + (job != -1 ? "jobRank = ?, jobRankMove = ? " : "`rank` = ?, rankMove = ? ") + "WHERE id = ?")) {
int rank = 0; int rank = 0;
while (rs.next()) { while (rs.next()) {