Sweetgum/sweetgum-server
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix exploit for invalid skill macro name length

Browse Source
This commit is contained in:
RubenD96
2021-04-07 17:26:49 +02:00
parent 32d4208761
commit 28707fa0f3
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/main/java/net/server/channel/handlers/SkillMacroHandler.java
View File

@@ -21,24 +21,35 @@
*/ */
package net.server.channel.handlers; package net.server.channel.handlers;
import client.MapleCharacter;
import client.MapleClient; import client.MapleClient;
import client.SkillMacro; import client.SkillMacro;
import tools.data.input.SeekableLittleEndianAccessor; import client.autoban.AutobanFactory;
import net.AbstractMaplePacketHandler; import net.AbstractMaplePacketHandler;
import tools.data.input.SeekableLittleEndianAccessor;
public final class SkillMacroHandler extends AbstractMaplePacketHandler { public final class SkillMacroHandler extends AbstractMaplePacketHandler {
@Override @Override
public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) { public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) {
MapleCharacter chr = c.getPlayer();
int num = slea.readByte(); int num = slea.readByte();
if (num > 5) return;
for (int i = 0; i < num; i++) { for (int i = 0; i < num; i++) {
String name = slea.readMapleAsciiString(); String name = slea.readMapleAsciiString();
if (name.length() > 12) {
AutobanFactory.PACKET_EDIT.alert(chr, "Invalid name length " + name + " (" + name.length() + ") for skill macro.");
c.disconnect(false, false);
break;
}
int shout = slea.readByte(); int shout = slea.readByte();
int skill1 = slea.readInt(); int skill1 = slea.readInt();
int skill2 = slea.readInt(); int skill2 = slea.readInt();
int skill3 = slea.readInt(); int skill3 = slea.readInt();
SkillMacro macro = new SkillMacro(skill1, skill2, skill3, name, shout, i); SkillMacro macro = new SkillMacro(skill1, skill2, skill3, name, shout, i);
c.getPlayer().updateMacros(i, macro); chr.updateMacros(i, macro);
} }
} }
} }