Sweetgum/sweetgum-server
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make PlayerStorage.getAllCharacters() return a copy (#386)

Browse Source 
* Clear continent drops when using !reloaddrops

* Return a copy on PlayerStorage.getAllCharacters()
This commit is contained in:
MedicOP
2019-02-03 13:50:51 +01:00
committed by Ronan Lana
parent a95728da84
commit 0a7aa8b05e
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/server/PlayerStorage.java
View File

@@ -84,7 +84,7 @@ public class PlayerStorage {
public Collection<MapleCharacter> getAllCharacters() { public Collection<MapleCharacter> getAllCharacters() {
rlock.lock(); rlock.lock();
try { try {
return storage.values(); return new ArrayList<>(storage.values());
} finally { } finally {
rlock.unlock(); rlock.unlock();
} }

6
src/net/server/world/World.java
View File

@@ -293,7 +293,7 @@ public class World {
} }
public void setExpRate(int exp) { public void setExpRate(int exp) {
List<MapleCharacter> list = new LinkedList<>(getPlayerStorage().getAllCharacters()); Collection<MapleCharacter> list = getPlayerStorage().getAllCharacters();
for(MapleCharacter chr : list) { for(MapleCharacter chr : list) {
if(!chr.isLoggedin()) continue; if(!chr.isLoggedin()) continue;
@@ -311,7 +311,7 @@ public class World {
} }
public void setDropRate(int drop) { public void setDropRate(int drop) {
List<MapleCharacter> list = new LinkedList<>(getPlayerStorage().getAllCharacters()); Collection<MapleCharacter> list = getPlayerStorage().getAllCharacters();
for(MapleCharacter chr : list) { for(MapleCharacter chr : list) {
if(!chr.isLoggedin()) continue; if(!chr.isLoggedin()) continue;
@@ -337,7 +337,7 @@ public class World {
} }
public void setMesoRate(int meso) { public void setMesoRate(int meso) {
List<MapleCharacter> list = new LinkedList<>(getPlayerStorage().getAllCharacters()); Collection<MapleCharacter> list = getPlayerStorage().getAllCharacters();
for(MapleCharacter chr : list) { for(MapleCharacter chr : list) {
if(!chr.isLoggedin()) continue; if(!chr.isLoggedin()) continue;