Staff with the new items.create permission (admins, and the new Developer
role) make clothing and den items from the game's own art: an existing
item under a new id (50000 on), name, price, members-only flag and choice
of its colours. No restart of the server or of anyone's game:
- lib/customitems.js keeps them (custom_items table) and puts them into
the server's tables and the packs new games fetch (defpacks.setCustomItem)
- games already playing get the def rows in "xdi"; so does every game at
login. The client adds them (ItemXtCommManager.addItemDefs,
DenXtCommManager.addDenItemDefs, both now in swf-src; rebuild with
tools/build-client.sh)
- they are sold first in the two shops of oddities and found by the item
finder; an item can be renamed, repriced, recoloured and taken off sale,
never deleted (players may own it)
- the moderator panel has an Items page; in game, "!item clothing|den ID
NAME" and "!item list"
- the Developer role holds only staff.list and items.create. The panel's
pages that show players (players, chat, reports, requests, bans,
paintings) now need player.view, which helpers and up have
test/items.js covers it end to end, including a restart (withServer can
keep its database for that).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The smoke, features, account and qol tests had fallen behind the server
and failed before reaching their end. Each now checks what the server
does on purpose today:
- harness: the chat filter messages the server sends unasked ("xfl"
after every login, "xfa" on the first room) are set aside like "zs".
- smoke: a banned account's sign-in is refused with "account_banned", so
the login-choices check uses a fresh account instead of the banned Carol.
- features: a shop's name comes from its room file, read the first time
anyone goes in (the first visitor sees a name made from the path). A
scout goes in first until the file is read, so the check no longer
depends on what an earlier run left in cache/.
- account: a deleted account's name is held for NAME_HELD_DAYS, so taking
it again right away is "username_taken".
- qol: the commands page sets what to type in italics.
And on Windows: withServer waits for the server process to exit before
removing its data directory, and retries; the database stays locked until
the process is gone, and the cleanup's EPERM hid the test's own result.
All seven test files pass (smoke, features, account, qol, buddygames,
restored, and staff in the next commit).
Co-Authored-By: Claude Opus 5.5 <[email protected]>