mirror of
https://github.com/burrow-dev/burrow-server.git
synced 2026-11-18 17:27:50 -05:00
fix(discord-bot): start the server without discord.js installed
b11ae1d made the server load discord.js at start, through lib/discordbot.js,
even with the bot off. update.sh installs no npm packages, so prod had none,
and every start failed with "Cannot find module 'discord.js'".
- lib/discordbot.js loads discord.js when the bot starts (a token and guild
id set), not with the server. without the package the bot stays off, with
a line in the log, and the panel's Start says to run npm ci. the two
message flags cards use are written as numbers, and the slash commands
are made when they are synchronized.
- deploy/update.sh runs npm ci --omit=dev when package-lock.json changed or
node_modules is missing. a failed install leaves the bot off; the game
needs no package.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
b11ae1dfa8
commit
a8ab031616
2 files changed
+41
-17
No files matched your search
@@ -47,6 +47,17 @@ for file in $(git diff --name-only "$old" "$new" -- '*.js'); do
|
||||
fi
|
||||
done
|
||||
|
||||
# the npm packages (only discord.js, for the optional Discord bot): installed
|
||||
# again when the lockfile changed, or when they never were. a failed install
|
||||
# leaves the bot off; the game itself needs none of them.
|
||||
if [ -f "$dir/package-lock.json" ] && { ! git diff --quiet "$old" "$new" -- package-lock.json || [ ! -d "$dir/node_modules" ]; }; then
|
||||
if command -v npm >/dev/null && runuser -u "$user" -- npm --prefix "$dir" ci --omit=dev --no-audit --no-fund; then
|
||||
echo "npm packages installed"
|
||||
else
|
||||
echo "npm packages could not be installed; the Discord bot stays off" >&2
|
||||
fi
|
||||
fi
|
||||
|
||||
# public/ is read from disk on every request; the rest is loaded once, at start.
|
||||
# the list is taken whole first: piped straight into grep -q, a long one (a
|
||||
# push of many files) had git cut off mid-write ("Broken pipe"), which
|
||||
|
||||
Reference in new issue
Block a user