mirror of
https://github.com/burrow-dev/burrow-server.git
synced 2026-11-18 17:27:50 -05:00
perf(defpacks): make the item packs again without holding the game up
A custom item change made the item and name packs again on the next fetch, on the one thread every game shares: ~360 ms at 5000 items, ~1.6 s at 50000, after every change, players making them many times a minute. Nearly all of it was the AMF3 writer. - the writer fills one growing buffer instead of a Buffer per value (byte-identical output, checked against the old one on every cached pack): the item pack 230 -> 52 ms at 5000 items, 1524 -> 231 ms at 50000. - a changed pack is made again at most every AJ_PACK_REMAKE_MS (15 s); until then the one made before goes out with the custom item version it has, and customItems.sendAll sends a game logging in what its packs lack by that version. one remake at a time; deflated on libuv's threads. - tests make the packs again at once (AJ_PACK_REMAKE_MS=0), and a run of the items test checks the throttled case. Busy evening simulated in-process (a change every 3 s, packs fetched 6 a second, 30 s): longest hold-up 329 -> 61 ms at 5000 items, 1648 -> 359 ms at 50000 (p99 240 -> 6 ms). Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
c5b1bc37d9
commit
04b8d325ea
7 files changed
+178
-64
No files matched your search
+6
-6
@@ -1049,14 +1049,14 @@ const handle = async (req, res) => {
|
||||
send(res, extra.body ? 200 : 404, extra.body || "Not found", extra.body ? extra.type : "text/plain");
|
||||
return;
|
||||
}
|
||||
// what custom items this game will have from its packs (customItems.sendAll)
|
||||
const packKind = defpacks.customPackKind(relPath);
|
||||
if (packKind) {
|
||||
customItems.sawPack(from.key, packKind);
|
||||
}
|
||||
const clientPack = await defpacks.clientPack(relPath);
|
||||
if (clientPack) {
|
||||
send(res, 200, clientPack, "application/octet-stream");
|
||||
// what custom items this game has from its packs (customItems.sendAll)
|
||||
const packKind = defpacks.customPackKind(relPath);
|
||||
if (packKind) {
|
||||
customItems.sawPack(from.key, packKind, clientPack.version);
|
||||
}
|
||||
send(res, 200, clientPack.body, "application/octet-stream");
|
||||
return;
|
||||
}
|
||||
// A room file in a seasonal theme ("<build>/roomDefs/theme_<other
|
||||
|
||||
Reference in new issue
Block a user